[95300] trunk/dports/devel/thrift/Portfile

[Blair Zajac]

On 07/13/2012 12:31 AM, Ryan Schmidt wrote:
> On Jul 13, 2012, at 01:40, Joshua Root wrote:
>> On 2012-7-13 15:01 , Blair Zajac wrote:
>>> On 07/12/2012 09:58 PM, Ryan Schmidt wrote:
>>>> On Jul 8, 2012, at 18:03, blair at macports.org wrote:
>>>>
>>>>> Revision: 95300
>>>>>           https://trac.macports.org/changeset/95300
>>>>> Author:   blair at macports.org
>>>>> Date:     2012-07-08 16:03:40 -0700 (Sun, 08 Jul 2012)
>>>>> Log Message:
>>>>> -----------
>>>>> thrift: whitespace only changes; indent using 8 spaces.
>>>>
>>>> Our style is to use 4 spaces per indent:
>>>>
>>>> http://guide.macports.org/#development.practices.portstyle
>>>>
>>>> That's also what the modeline in the port says it will use:
>>>>
>>>>> # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil;
>>>>> c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
>>>
>>> That's going to be quite a few portfiles to change :)
>>
>> Indentation style is up to the maintainer; just make sure it's
>> consistent within each portfile and matches what the modeline says.
>
> Right. But if you're going to go to the effort of making a special commit just to change a portfile's whitespace, then it would be appreciated if you would change it to the standard whitespace style that's described in the guide.

The style I've been using for all my portfiles have been with 8 spaces 
and was in the process of working on this port.  Next time I go through 
and make whitespace changes I'll switch to 4 spaces.

Blair