[MacPorts] #34784: Add perl5.branches to all p5 ports (adding p5.16 for perl5.16)

[Bjarne D Mathiesen]

MacPorts wrote:
> #34784: Add perl5.branches to all p5 ports (adding p5.16 for perl5.16)
> -------------------------------------+--------------------------------------
>  Reporter:  ryandesign@…             |       Owner:  macports-tickets@…                   
>      Type:  enhancement              |      Status:  new                                  
>  Priority:  Normal                   |   Milestone:                                       
> Component:  ports                    |     Version:  2.1.1                                
>  Keywords:                           |        Port:                                       
> -------------------------------------+--------------------------------------
> 
> Comment(by ryandesign@…):
> 
>  Replying to [ticket:34784 ryandesign@…]:
>  > In r93584 the perl5 portgroup was updated to add "5.16" to
>  perl5.branches
> 
>  I reverted this in r94024.
> 
>  > but this is not the correct way to do this.
> 
>  The reason this does not work is that the p5.16 subports don't get added
>  to the portindex until the ports are reindexed. This only happens when a
>  port is updated. So ever since r93584 this means when a port is updated,
>  that has dependencies that haven't been updated since that change, the
>  buildbot will fail to build the p5.16 subport, because its dependencies
>  don't seem to have p5.16 subports yet.
> 
>  > Instead, every p5 port needs the perl5.branches line added to it
> 
>  Once this is done, the default for perl5.branches needs to be removed from
>  the perl5 portgroup.
> 

Is it enough to just move that line around ???
Isn't it necessary to rev-bump the p5-* ports too ???

This is the piece of code in question :
# portfile configuration options
# perl5.branches: the major perl version supported by this module. A
#   subport will be created for each. e.g. p5.12-foo, p5.10-foo, ...
# perl5.default_branch: the branch used when you request p5-foo
options perl5.default_branch perl5.branches
default perl5.branches {"5.8 5.10 5.12 5.14 5.16"}
default perl5.default_branch {[perl5_get_default_branch]}
proc perl5_get_default_branch {} {
    global prefix
    # use whatever ${prefix}/bin/perl5 was chosen, and if none, fall
back to 5.12
    if {![catch {set val [lindex [split [exec ${prefix}/bin/perl5
-V:version] {'}] 1]}]} {
        return [join [lrange [split $val .] 0 1] .]
    } else {
        return 5.12
    }
}

Q : in any given p5-* port, should the line be
default perl5.branches {"5.8 5.10 5.12 5.14 5.16"}
set perl5.branches {"5.8 5.10 5.12 5.14 5.16"}

-- 
Bjarne D Mathiesen
København N ; Danmark ; Europa
----------------------------------------------------------------------
denne besked er skrevet i et totalt M$-frit miljø
MacOS X 10.7.3 Lion ; 2.8GHz Intel Core i7 ; 16GB 1067MHz DDR3