[90329] trunk/dports/lang/sbcl/Portfile

Mark Evenson evenson at panix.com
Sun Mar 4 02:21:29 PST 2012


I won't be back to my Mac until Monday, but I will then address the style issues caused by my recent commits to lang/sbcl.

Just some quick comments to the style issues:

The error message from whatever is emitting the lint message on Portffile commit should be fixed to indicate that the RCS Id keyword may be placed on the second line of a Portfile.

The intention of breaking the greater than 80 char comment line with the concatenated initialization instructions for vim/Emacs was to facilitate human editing.

As for the attempt at introducing multiline variant descriptions bounded by a Pythonesque triple  double-quote, the motivation was to introduce a more human-friendly syntax that would not require backslash escapes for many common characters.  It seemed to work in my tests, but I will revert to the previous form as requested.

Again, I will revert to the conventions outlined by Ryan when I get a chance but offer these comments to elucidate my thinking. 

Sent from my iPad

On Mar 4, 2012, at 6:18 AM, Ryan Schmidt <ryandesign at macports.org> wrote:

> 
> On Mar 2, 2012, at 04:30, easieste at macports.org wrote:
> 
>> Revision: 90329
>>         http://trac.macports.org/changeset/90329
>> Author:   easieste at macports.org
>> Date:     2012-03-02 02:30:54 -0800 (Fri, 02 Mar 2012)
>> Log Message:
>> -----------
>> macports:lang/sbcl Satisfy lint by placing the RCS Id keyword in the first physical line.
>> 
>> Modified Paths:
>> --------------
>>   trunk/dports/lang/sbcl/Portfile
>> 
>> Modified: trunk/dports/lang/sbcl/Portfile
>> ===================================================================
>> --- trunk/dports/lang/sbcl/Portfile    2012-03-02 10:13:30 UTC (rev 90328)
>> +++ trunk/dports/lang/sbcl/Portfile    2012-03-02 10:30:54 UTC (rev 90329)
>> @@ -1,6 +1,6 @@
>> +# $Id$
>> # vim:fenc=utf-8:filetype=tcl:et:sw=4:ts=4:sts=4
>> # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- 
>> -# $Id$
> 
> The modeline should be the first line, and the $Id$ line should be the second line, as it shows in the Guide and in most existing portfiles.
> 
> 


More information about the macports-dev mailing list