[90767] trunk/dports/cross/msp430-gdb/Portfile

[Aljaž Srebrnič]

On 14/mar/2012, at 09:32, Ryan Schmidt wrote:

> 
> On Mar 14, 2012, at 03:14, g5pw at macports.org wrote:
> 
>> Revision: 90767
>>         http://trac.macports.org/changeset/90767
>> Author:   g5pw at macports.org
>> Date:     2012-03-14 01:14:28 -0700 (Wed, 14 Mar 2012)
>> Log Message:
>> -----------
>> msp430-gdb:
>> - Updated maintainer address
>> - Eliminated the use of the epoch keyword
> 
> It looks like you did several things in this changeset, but the word "epoch" does not appear anywhere in this changeset, so removing it wasn't one of the changes.

Hmm… Looks like i diffed agains the wrong file :P

> 
> Do be aware however that if there is an epoch line in a portfile, it can never be removed, nor can its value ever be decreased.

Ah ok. Yes, using it was a mistake in the first place.

> 
> 
>> Modified Paths:
>> --------------
>>   trunk/dports/cross/msp430-gdb/Portfile
>> 
>> Modified: trunk/dports/cross/msp430-gdb/Portfile
>> ===================================================================
>> --- trunk/dports/cross/msp430-gdb/Portfile	2012-03-14 07:46:16 UTC (rev 90766)
>> +++ trunk/dports/cross/msp430-gdb/Portfile	2012-03-14 08:14:28 UTC (rev 90767)
>> @@ -4,14 +4,17 @@
>> PortSystem              1.0
>> 
>> name                    msp430-gdb
>> -version                 7.2
>> +set name_target         [lindex [split ${name} -] 0]
>> +set name_package        [lindex [split ${name} -] 1]
>> +set version_base        7.2
>> +set lts_date        	20110103
> 
> A tab character snuck in on this line, but per our preferred style, and per the modeline in this portfile, there should be no tabs, only spaces. You may wish to configure your editor to insert spaces instead of tab characters when you press the tab key.

Ah! good find. I usually use vim, but it looks like that tab snuck in whan I was (briefly) using another editor.

> 
> 
>> +version                 ${version_base}-${lts_date}
>> +conflicts               ${name}-devel
>> 
>> -distname                gdb-${version}
>> -set crossgcc-target     msp430
>> -set version_date        20110103
>> +distname                ${name_package}-${version_base}
>> 
>> categories              cross
>> -maintainers             gmail.com:a2piratesoft nomaintainer
>> +maintainers             g5pw
>> description             GDB for the MSP430 processors
>> long_description        msp430-gdb is a version of the GNU Debugger that \
>>                        through the mspdebug program can be used to debug \
>> @@ -22,7 +25,7 @@
>> master_sites            gnu:gdb
>> patch_sites             http://downloads.sourceforge.net/project/mspgcc/Patches/${distname}/
>> use_bzip2               yes
>> -checksums               ${name}-${version}-${version_date}.patch \
>> +checksums               ${name}-${version}.patch \
>>                        rmd160  09d8427721b0a54ecddda373fcd5af6f9496e55c \
>>                        sha256  5631fce178ed3bf05b6c60957e56501ea22b3618febc2fa790249a1b86447aa0 \
>>                        ${distname}${extract.suffix} \
>> @@ -30,11 +33,11 @@
>>                        sha256  bf444b88ab845243364c3d410be9e3f43a57f96ff594d65a37842ea03c3410f0
>> depends_run             port:mspdebug
>> 
>> -patchfiles              ${name}-${version}-${version_date}.patch
>> +patchfiles              ${name}-${version}.patch
>> 
>> -worksrcdir              gdb-[string trimright ${version} a-zA-Z]
>> +worksrcdir              ${distname}
> 
> You can remove the line "worksrcdir ${distname}"; that's the default.

Will do, thanks!

Aljaž Srebrnič
-- --
My public key:  http://bit.ly/g5pw_pubkey