[90862] trunk/dports/devel

[Aljaž Srebrnič]

On 16/mar/2012, at 16:04, Ryan Schmidt wrote:

> 
> On Mar 16, 2012, at 04:35, g5pw at macports.org wrote:
> 
>> Revision: 90862
>>         https://trac.macports.org/changeset/90862
>> Author:   g5pw at macports.org
>> Date:     2012-03-16 02:35:56 -0700 (Fri, 16 Mar 2012)
>> Log Message:
>> -----------
>> devel/radare2:
>> New port
> 
> https://trac.macports.org/ticket/32560 had been filed for this. Does this commit address all the issues discussed there? / Can the ticket be closed?

It was me who filed this ticket. It can be safely closed.

> 
> 
>> Added Paths:
>> -----------
>>   trunk/dports/devel/radare2/
>>   trunk/dports/devel/radare2/Portfile
>>   trunk/dports/devel/radare2/change_install_names
> 
> This file does not appear to be used.
> 
> 
>>   trunk/dports/devel/radare2/files/
>>   trunk/dports/devel/radare2/files/patch-change_install_names.diff
> 
> This patch appears to create the above script in the worksrcpath.
> 
> We usually just put the script itself into the files directory, and either call it from there or copy it into the worksrcpath, rather than writing a patch that creates a file, since it's easier to edit a script itself than to edit a patch that creates a script.

Done! Will commit as soon as I fix some things with the developers.

> 
> 
>>   trunk/dports/devel/radare2/files/patch-libr-Makefile.diff
>>   trunk/dports/devel/radare2/files/patch-libr-config.mk.tail.diff
>>   trunk/dports/devel/radare2/files/patch-libr-rules.mk.diff
>>   trunk/dports/devel/radare2/files/patch-mk-gcc.mk.diff
>> 
>> Added: trunk/dports/devel/radare2/Portfile
>> ===================================================================
>> --- trunk/dports/devel/radare2/Portfile	                        (rev 0)
>> +++ trunk/dports/devel/radare2/Portfile	2012-03-16 09:35:56 UTC (rev 90862)
>> @@ -0,0 +1,33 @@
>> +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=portfile:sw=4:ts=4:sts=4
>> +# $Id$
>> +
>> +PortSystem          1.0
>> +
>> +name				radare2
>> +version				0.9
>> +categories			devel
>> +platforms           darwin
>> +license             GPL-3
> 
> According to my notes in #32560 the license is actually "LGPL-3+".

You're right. Corrected!

> 
> 
>> +maintainers			g5pw pixilla openmaintainer
>> +description			Opensource tools to disasm, debug, analyze and manipulate binary files.
>> +long_description    ${description}
>> +homepage			http://radare.org/
>> +master_sites		${homepage}get/
>> +
>> +checksums           ${distname}${extract.suffix} \
> 
> Note that you don't have to list the distfile name when there's only one.

Just being explicit :) But yeah, it's redundant.

> 
> 
>> +						rmd160  f68ebf07ec62e907980e8f8bc195754bf993b466 \
>> +						sha256  e12feea3b776601d7b680e64250897110cf4fca2f1214b4c527e13b7abe900e0
>> +
>> +patch.pre_args      -p1
>> +patchfiles          patch-change_install_names.diff \
> 
>> +                    patch-libr-Makefile.diff \
>> +                    patch-libr-config.mk.tail.diff \
>> +                    patch-libr-rules.mk.diff \
>> +                    patch-mk-gcc.mk.diff
>> +
>> +build.env-append "LDFLAGS=-L${prefix}/lib"
> 
> Note that you don't need to quote this, and also that -L${prefix}/lib is known in MacPorts as ${configure.ldflags}. The fact that you're having to manually add this to LDFLAGS makes me wonder what else (-arch flags?) you might have to manually deal with (see #32560).

Actually I have a valid reason to do that, the makefile looks a little bugged. I will contact the devs and see if they can fix it upstream.

> 
> 
>> +post-destroot {
>> +    # Fix link lib paths
>> +    system "cd ${worksrcpath} && sh change_install_names ${destroot}"
> 
> Note that "system" has a "-W" argument that should be used instead of manually "cd"ing somewhere.
> 
> system -W ${worksrcpath} "sh change_install_names ${destroot}"
> 
> Or, if you decide to move the actual script into the files directory and call it from there, as I suggested above, perhaps just:
> 
> system "sh ${filespath}/change_install_names ${destroot}"

Corrected!

> 
> 
>> Added: trunk/dports/devel/radare2/change_install_names
>> ===================================================================
>> --- trunk/dports/devel/radare2/change_install_names	                        (rev 0)
>> +++ trunk/dports/devel/radare2/change_install_names	2012-03-16 09:35:56 UTC (rev 90862)
>> @@ -0,0 +1,74 @@
>> +#!/bin/sh
>> +
>> +# Be noise.
> 
> You mean "noisy"?

Yeah, of course :)

> 
>> +VERBOSE=no
>> +# Stop on path failures.
>> +STOP=no
> 
> 
> [snip]



Aljaž Srebrnič
-- --
My public key:  http://bit.ly/g5pw_pubkey