[91385] trunk/dports/devel/orc/Portfile

[Jeremy Huddleston]

On Mar 31, 2012, at 11:24 AM, Joshua Root <jmr at macports.org> wrote:

>> Revision: 91385
>>          https://trac.macports.org/changeset/91385
>> Author:   jeremyhu at macports.org
>> Date:     2012-03-31 01:14:17 -0700 (Sat, 31 Mar 2012)
>> Log Message:
>> -----------
>> orc: Mark as intel only to match the Portfile's optflags
>> 
>> Modified Paths:
>> --------------
>>    trunk/dports/devel/orc/Portfile
>> 
>> Modified: trunk/dports/devel/orc/Portfile
>> ===================================================================
>> --- trunk/dports/devel/orc/Portfile	2012-03-31 03:54:31 UTC (rev 91384)
>> +++ trunk/dports/devel/orc/Portfile	2012-03-31 08:14:17 UTC (rev 91385)
>> @@ -22,6 +22,8 @@
>>                     patch_orc-test_orcarray.c.diff \
>>                     patch_config.h.in.diff
>> 
>> +supported_archs     i386 x86_64
>> +
>> configure.optflags-append -Xarch_i386 -O1
> 
> Did this really fail on ppc?

Yes, it really failed on ppc, but I addressed that in the +1 revision by moving to muniversal.

> My understanding was that the extra
> optflags here should have just used -O1 for the i386 build, and done
> nothing for other archs.

That is true.  I misread it as -Darch_i386 the first time.  Notice that in the +1 muniversal revision, this functionality is preserved using the muniversal cflags.

> IIRC it may not work on Tiger, but that's a different issue. (The
> workaround probably also isn't needed for every compiler...)

I dunno about Tiger.  I haven't gotten that far on my Tiger build.  This was encountered with my i386 x86_64 ppc Leopard build.

--Jeremy