[92811] trunk/dports/devel/dbus/Portfile

[Ryan Schmidt]

On May 7, 2012, at 10:46, Bradley Giesbrecht wrote:

> 
> On May 7, 2012, at 8:41 AM, ryandesign at macports.org wrote:
> 
>> Revision
>> 92811
>> Author
>> ryandesign at macports.org
>> Date
>> 2012-05-07 08:41:02 -0700 (Mon, 07 May 2012)
>> Log Message
>> 
>> dbus: use startup_root variable when setting launchd plist attributes
>> Modified Paths
>> 
>> 	• trunk/dports/devel/dbus/Portfile
>> Diff
>> 
>> Modified: trunk/dports/devel/dbus/Portfile (92810 => 92811)
>> 
>> --- trunk/dports/devel/dbus/Portfile	2012-05-07 13:49:16 UTC (rev 92810)
>> +++ trunk/dports/devel/dbus/Portfile	2012-05-07 15:41:02 UTC (rev 92811)
>> 
>> @@ -168,8 +168,8 @@
>> 
>>     file attributes ${prefix}/libexec/dbus-daemon-launch-helper -group ${dbus_group}
>> 
>> 
>> 
>>     if { [variant_isset startupitem] && ![variant_isset no_root] } {
>> 
>> -        file attributes /Library/LaunchAgents/org.freedesktop.dbus-session.plist -owner root -group wheel
>> -        file attributes /Library/LaunchDaemons/[file tail ${plistFl}] -owner root -group wheel
>> 
>> +        file attributes ${startup_root}/Library/LaunchAgents/org.freedesktop.dbus-session.plist -owner root -group wheel
>> +        file attributes ${startup_root}/Library/LaunchDaemons/[file tail ${plistFl}] -owner root -group wheel
> 
> These are both symlinks. My patch was to set the attributes on the actual files which are always at the same place.
> +        file attributes ${prefix}/Library/LaunchAgents/org.freedesktop.dbus-session.plist -owner root -group wheel
> +        file attributes ${prefix}/Library/LaunchDaemons/[file tail ${plistFl}] -owner root -group wheel

Ok, that sounds fine.

I guess my change was a no-op anyway because startup_root is "" when ![variant_isset no_root].


> Also, does port keep a copy of the binary package? Do we need to revbump?


The packages server keeps copies of the binary packages:

http://packages.macports.org/dbus/

So if you are committing a change that will change what goes into the package, then a revbump is needed. As demonstrated in #34349 the current dbus-1.4.20_0+startupitem.darwin_11.x86_64.tbz2 package at least does not install, so a revbump will be needed when a fix for that is committed.