breakage from r99712

[Bradley Giesbrecht]

On Nov 17, 2012, at 11:30 AM, Jack Howarth wrote:

> On Sat, Nov 17, 2012 at 12:23:13PM -0500, Jeremy Lavergne wrote:
>>>  Am I reading this wrong...
>>> 
>>> http://trac.macports.org/ticket/126
>>> 
>>> It seems to imply that MacPorts doesn't allow a Portfile to enforce a variant in depends_lib?
>> 
>> We can get around this a few ways:
>> * PortGroup active_variants
>> * subports of tcl/tk
>> 
>>> This seems like a horrible situation and we have just shifted the pain and suffering around.
>>> The current situation allows packages like pymol to become randomly broken and will totally
>>> confound end-users.
>> 
>> Sounds like switching the variants to subports will mitigate the issue.
> 
> Jeremy,
>   The addition of the +x11 variant to tk is insufficient (but neccessary) to solve this
> problem with pymol. It still fails with...
> 
> Detected OpenGL version 2.0 or greater. Shaders available.
> Detected GLSL version 1.20.
> OpenGL graphics engine:
>  GL_VENDOR: ATI Technologies Inc.
>  GL_RENDERER: ATI Radeon X1600 OpenGL Engine
>  GL_VERSION: 2.1 ATI-7.4.1
> Detected 2 CPU cores.  Enabled multithreaded rendering.
> OpenGL quad-buffer stereo 3D detected and enabled.
> Tcl_WaitForEvent: CFRunLoop finished
> Abort
> 
> You need to provide users with a +nocorefoundation variant on tcl as well.
> The following Portfile.diff allows pymol to work again in concert with
> the +x11 variant of tk and the +nocorefoundation variant of tcl...
> 
> --- Portfile.orig       2012-11-17 14:21:11.000000000 -0500
> +++ Portfile    2012-11-17 14:22:30.000000000 -0500
> @@ -4,6 +4,7 @@
> 
> name          tcl
> version       8.5.13
> +revision      1
> # Tk (x11/tk) port depends on this version
> categories    lang
> license       Tcl/Tk
> @@ -53,6 +54,9 @@
>     variant corefoundation description {Enable CoreFoundation support (not fork-safe)} {
>         configure.args-delete --disable-corefoundation
>     }
> +    variant nocorefoundation description {Disable CoreFoundation support (fork-safe)} {
> +       configure.args-append --disable-corefoundation
> +    }
>     # tk +quartz crashes at launch without CF support
>     default_variants +corefoundation

If there is already a corefoundation variant there is no need to create another variant to counteract it:
sudo port install tcl -corefoundation

And possibly change default_variants:
default_variants -corefoundation

Regards,
Bradley Giesbrecht (pixilla)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2763 bytes
Desc: not available
URL: <http://lists.macosforge.org/pipermail/macports-dev/attachments/20121117/9a7fd2f1/attachment.p7s>