[97757] trunk/dports

[David Evans]

On 9/14/12 10:01 AM, Ryan Schmidt wrote:
> On Sep 14, 2012, at 11:40, devans at macports.org wrote:
>
>> Revision: 97757
>>          http://trac.macports.org//changeset/97757
>> Author:   devans at macports.org
>> Date:     2012-09-14 09:40:55 -0700 (Fri, 14 Sep 2012)
>> Log Message:
>> -----------
>> poppler: update to version 0.20.4.
>
>
>> Modified: trunk/dports/graphics/opencv/Portfile
>> ===================================================================
>> --- trunk/dports/graphics/opencv/Portfile	2012-09-14 16:11:09 UTC (rev 97756)
>> +++ trunk/dports/graphics/opencv/Portfile	2012-09-14 16:40:55 UTC (rev 97757)
>> @@ -43,12 +43,16 @@
>>                                 port:ilmbase \
>>                                 port:eigen3
>>
>> +post-extract {
>> +    system "chmod -R 755 ${worksrcpath}"
>> +}
>> +
>> patchfiles                      patch-fix_dirname_case.diff \
>>                                 patch-install_name.diff
>>
>> -if {[variant_isset universal]} {
>> -    patchfiles-append           patch-pch-CMakeLists.txt.diff
>> -}
>> +#if {[variant_isset universal]} {
>> +#    patchfiles-append           patch-pch-CMakeLists.txt.diff
>> +#}
>>
>> configure.args-append           -DBUILD_NEW_PYTHON_SUPPORT=OFF \
>>                                 -DBUILD_EXAMPLES=ON \
>>
> Was this change supposed to be committed here? It doesn't appear to relate to the poppler update.
>
> You should not use "system" just to run "chmod" to change permissions; instead, use "file attributes -permissions":
>
> http://www.tcl.tk/man/tcl8.4/TclCmd/file.htm#M6
>
>
No, it wasn't, but it slipped in by accident.  The changes that you
mention were done for ease of debugging only. 

The only connection is that it's a dependency of auto-multiple-choice
which does depend on poppler.  Note that this poppler update
only increments the version of libpoppler itself not the other libs
contained therein so only the poppler dependents that directly link
to libpoppler (not libpoppler-glib, libpoppler-qt, etc) were rebuilt.

Cleaned up in r97768.