[105069] trunk/dports/gnome/epiphany/Portfile

[Ryan Schmidt]

On Apr 8, 2013, at 19:03, devans at macports.org wrote:

> Revision: 105069
>          https://trac.macports.org/changeset/105069
> Author:   devans at macports.org
> Date:     2013-04-08 17:03:41 -0700 (Mon, 08 Apr 2013)
> Log Message:
> -----------
> epiphany: builds universal if nss support is disabled.
> 
> Modified Paths:
> --------------
>    trunk/dports/gnome/epiphany/Portfile
> 
> Modified: trunk/dports/gnome/epiphany/Portfile
> ===================================================================
> --- trunk/dports/gnome/epiphany/Portfile	2013-04-08 23:14:51 UTC (rev 105068)
> +++ trunk/dports/gnome/epiphany/Portfile	2013-04-09 00:03:41 UTC (rev 105069)
> @@ -64,6 +64,9 @@
> # nss is not universal
> #
> 
> -universal_variant no
> +if {[variant_isset universal]} {
> +        configure.args-append --disable-nss
> +        depends_lib-delete port:nss
> +}

This is confusing; I don't think anyone would expect a port to silently drop some features when building universal.

To make this situation clear to the user, I'd make an nss variant. Make it a default_variant if the universal variant is not selected. And mark it as conflicting with the nss variant. That should cover all the bases. And this way, a port that depends on epiphany can indicate (with the active_variants portgroup) if it requires epiphany with nss support.