[105273] trunk/dports/mail

[Ryan Schmidt]

On Apr 15, 2013, at 14:20, pixilla at macports.org wrote:

> Revision: 105273
>          https://trac.macports.org/changeset/105273
> Author:   pixilla at macports.org
> Date:     2013-04-15 12:20:35 -0700 (Mon, 15 Apr 2013)
> Log Message:
> -----------
> mail/dovecot2:
> - Add upstream patch.
> mail/dovecot2-sieve:
> - Update to version 0.3.4.
> - No longer include hg.tag in version number.
> - Add comment to revbump on hg.tag changes.


> Modified: trunk/dports/mail/dovecot2-sieve/Portfile

> @@ -34,13 +36,7 @@
> use_bzip2           yes
> 
> if {${hg.tag} != ${version}} {
> -    version             ${version}-${hg.tag}
> 
> -    depends_build       port:libtool port:autoconf
> -    pre-configure {
> -        system "cd ${worksrcpath} && ./autogen.sh"
> -    }
> -
>     livecheck.url       [lindex ${master_sites} 0]
>     livecheck.type      regex
>     livecheck.url       http://hg.rename-it.nl/dovecot-${dovecot2}-pigeonhole/log
> @@ -62,6 +58,14 @@
> 
> depends_lib         port:dovecot2
> 
> +pre-configure {
> +    if {![file exists "${worksrcpath}/configure"]} {
> +
> +        depends_build-append port:libtool port:autoconf
> +        system "cd ${worksrcpath} && ./autogen.sh"
> +    }
> +}

Inside a phase is too late to add dependencies.

Use 'system -W ${worksrcpath} "…"' instead of 'system "cd ${worksrcpath} && …'

Why would the configure script sometimes exist and sometimes not?