[105337] trunk/dports/math/atlas/Portfile

[Ryan Schmidt]

On Apr 18, 2013, at 01:40, Blair Zajac wrote:

> On 04/17/2013 11:14 PM, Lawrence Velázquez wrote:
>> On Apr 18, 2013, at 2:12 AM, vince at macports.org wrote:
>> 
>>> Revision: 105337
>>>          https://trac.macports.org/changeset/105337
>>> Author:   vince at macports.org
>>> Date:     2013-04-17 23:12:08 -0700 (Wed, 17 Apr 2013)
>>> Log Message:
>>> -----------
>>> Re-enables threading for ppc if necessary.
>>> 
>>> Modified Paths:
>>> --------------
>>>    trunk/dports/math/atlas/Portfile
>>> 
>>> Modified: trunk/dports/math/atlas/Portfile
>>> ===================================================================
>>> --- trunk/dports/math/atlas/Portfile	2013-04-18 00:31:56 UTC (rev 105336)
>>> +++ trunk/dports/math/atlas/Portfile	2013-04-18 06:12:08 UTC (rev 105337)
>>> @@ -333,6 +333,7 @@
>>> 
>>>     configure.args-append    -t 0
>>>     set no_threads  1
>>> +    exec sed -i bak -E "/.*threads.*/d" ${worksrcpath}/Make.top
>> 
>> Is there some reason you're using "exec sed" for this instead of a copy+reinplace?
> 
> I got this error syncing just now:
> 
> Creating port index in /opt/local/var/macports/sources/rsync.macports.org/release/ports
> Failed to parse file math/atlas/Portfile: sed: /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_math_atlas/atlas/work/atlas-3.10.1/Make.top: No such file or directory

Right. You cannot go replacing things in files before those files exist. You need to do this in a phase. A post-patch block is probably most logical.