[105547] trunk/base/src/port1.0/portconfigure.tcl

[Ryan Schmidt]

On Apr 24, 2013, at 13:19, jeremyhu at macports.org wrote:

> Revision: 105547
>          https://trac.macports.org/changeset/105547
> Author:   jeremyhu at macports.org
> Date:     2013-04-24 11:19:51 -0700 (Wed, 24 Apr 2013)
> Log Message:
> -----------
> Point users to config.log on configure failure if it exists
> 
> Modified Paths:
> --------------
>    trunk/base/src/port1.0/portconfigure.tcl
> 
> Modified: trunk/base/src/port1.0/portconfigure.tcl
> ===================================================================
> --- trunk/base/src/port1.0/portconfigure.tcl	2013-04-24 16:39:46 UTC (rev 105546)
> +++ trunk/base/src/port1.0/portconfigure.tcl	2013-04-24 18:19:51 UTC (rev 105547)
> @@ -750,6 +750,10 @@
> 
>         # Execute the command (with the new environment).
>         if {[catch {command_exec configure} result]} {
> +            global configure.dir
> +            if {[file exists ${configure.dir}/config.log]} {
> +                ui_error "[format [msgcat::mc "Failed to configure %s, consult %s/config.log"] [option subport] ${configure.dir}]"
> +            }
>             return -code error "[format [msgcat::mc "%s failure: %s"] configure $result]"
>         }
>     }

This is a place where it would be useful to have muniversal functionality in base instead of in a portgroup, because when using muniversal, that's not where the config.log would be (so ports using muniversal will currently never print this message, even if sometimes it would be applicable).