[109325] trunk/dports/net/FreeRDP

[Ryan Schmidt]

On Aug 13, 2013, at 13:13, Joshua Root wrote:
> On 2013-8-13 18:54 , Ryan Schmidt wrote:
>> On Aug 13, 2013, at 02:58, Jeremy Huddleston Sequoia wrote:
>> 
>>> On Aug 12, 2013, at 23:10, devans at macports.org wrote:
>>> 
>>>> --- trunk/dports/net/FreeRDP/Portfile	2013-08-13 05:52:15 UTC (rev 109324)
>>>> +++ trunk/dports/net/FreeRDP/Portfile	2013-08-13 06:10:32 UTC (rev 109325)
>>>> @@ -5,7 +5,7 @@
>>>> 
>>>> PortGroup   cmake   1.0
>>>> 
>>>> github.setup        FreeRDP FreeRDP 1.1.0-beta+2013071101
>>> 
>>> I just noticed that buildports-mtln-x86_64 failed cleanup after building this.
>>> 
>>> https://build.macports.org/builders/buildports-mtln-x86_64/builds/7018/steps/cleanup/logs/stdio
>>> 
>>> I'm guessing that version number is the culprit.
>> 
>> Yeah, "+" is not a valid character to use in version numbers because MacPorts confuses what follows with a variant name. (Oddly, MacPorts handles "-" in a version number ok.)
> 
> '-' can never occur in the canonical active variants string.
> 
> Unfortunately this may require manual intervention to fix even after the
> version in the Portfile is changed to something valid.

We should add a check to "port lint" for "+" in version number.