[109333] trunk/dports/devel/akonadi/Portfile

[Ryan Schmidt]

On Aug 13, 2013, at 10:01, nicos at macports.org wrote:

> Revision: 109333
>          https://trac.macports.org/changeset/109333
> Author:   nicos at macports.org
> Date:     2013-08-13 08:01:18 -0700 (Tue, 13 Aug 2013)
> Log Message:
> -----------
> akonadi: update to 1.10.2, add missing sql-server dependendies, add a startup item to run server
> 
> Modified Paths:
> --------------
>    trunk/dports/devel/akonadi/Portfile


> +notes " ##############################################################################
> + # Applications using akonadi need the akonadi server to be running to function.
> + # To start the server manually, run
> + # akonadictl start &
> + # Otherwise, an agent to start the server at logon is provided.
> + # To start it run the following command:
> + # launchctl load -w ${startup_root}/Library/LaunchDaemons/org.macports.akonadi.plist
> + ##############################################################################"

You should not use ASCII art to enclose your notes in a box to make it appear more prominently. Allow MacPorts to display the notes normally. If the MacPorts presentation of notes is not prominent enough, then surely that should be fixed in MacPorts base so that all ports can benefit, rather than each port doing it its own way.


> +variant no_root description {Run the akonadi server start as MacPorts install user.} {
> +    pre-fetch {
> +        if { ${install.user}=="root" || ${install.group}=="wheel" } {
> +            ui_error "The akonadi server should not be run as root with no_root variant."
> +            error "Please do not use this variant with your MacPorts configuration."
> +        }
> +    }
> +
> +    set startup_root  [join [lrange [exec /usr/bin/dscl . -read Users/${install.user} NFSHomeDirectory] 1 end]]
> +    # Files are installed into user's startup directory.
> +    destroot.violate_mtree  yes
> +}

Variant names beginning with "no_" are deprecated; please don't create new ones. Usually you should instead use a positively-named variant and use default_variants to turn it on by default, but in this case that would be weird too since this variant implements a nonstandard function. Is a variant really needed at all? Couldn't the port detect whether the user's MacPorts install is as root or not, and react accordingly? That would seem best.