[110366] trunk/dports/graphics/wxWidgets-3.0

[Ryan Schmidt]

On Aug 30, 2013, at 13:18, mojca at macports.org wrote:

> Revision: 110366
>          https://trac.macports.org/changeset/110366
> Author:   mojca at macports.org
> Date:     2013-08-30 11:18:10 -0700 (Fri, 30 Aug 2013)
> Log Message:
> -----------
> wxWidgets-3.0: minor cosmetic changes only
> 
> Modified Paths:
> --------------
>    trunk/dports/graphics/wxWidgets-3.0/Portfile
>    trunk/dports/graphics/wxWidgets-3.0/files/patch-include-wx-math.h.diff
> 
> Modified: trunk/dports/graphics/wxWidgets-3.0/Portfile
> ===================================================================
> --- trunk/dports/graphics/wxWidgets-3.0/Portfile	2013-08-30 18:08:37 UTC (rev 110365)
> +++ trunk/dports/graphics/wxWidgets-3.0/Portfile	2013-08-30 18:18:10 UTC (rev 110366)
> @@ -20,10 +20,6 @@
> } elseif {$subport == "wxPython-3.0"} {
>     wxWidgets.use   wxPython-3.0
>     version         2.9.4
> -    revision            1
> -    set wxpythonsubset wxPython-2.9.4.0-MacPorts-subset
> -    # temporary patch for 2.9.4 only; already integrated into 2.9.5
> -    patchfiles-append patch-include-wx-math.h.diff
> } elseif {$subport == "wxgtk-3.0"} {
>     # with satisfactory Cocoa support there is no real need for GTK-based wxWidgets any more
>     # wxgtk-3.0 is here mainly for testing purposes
> @@ -102,10 +98,13 @@
>                     --with-macosx-version-min=no
> 
> if {$subport == "wxPython-3.0"} {
> +    set wxpythonsubset      wxPython-2.9.4.0-MacPorts-subset
>     distfiles-append        ${wxpythonsubset}${extract.suffix}:trac
> 
>     # patch-src-osx-cocoa-window.mm.diff: http://trac.wxwidgets.org/changeset/72195 (only needed for 2.9.4)
> -    patchfiles-append       patch-src-osx-cocoa-window.mm.diff
> +    # patch-include-wx-math.h.diff:       http://trac.wxwidgets.org/changeset/74456 (only needed for 2.9.4)
> +    patchfiles-append       patch-src-osx-cocoa-window.mm.diff \
> +                            patch-include-wx-math.h.diff

It's probably a good idea to keep a revision line in each subport. You don't always want them to be increased as a group, and somebody editing the port might not realize that changing the revision at the top of the portfile would change the revision for all subports.