[114581] trunk/dports/graphics/gimp2-devel

[Ryan Schmidt]

On Dec 10, 2013, at 12:02, devans at macports.org wrote:

> Revision
> 114581
> Author
> devans at macports.org
> Date
> 2013-12-10 10:02:36 -0800 (Tue, 10 Dec 2013)
> Log Message
> 
> gimp2-devel: new development version of gimp2 based on a snapshort of recent git master.
> Modified Paths
> 
> 	• trunk/dports/graphics/gimp2-devel/Portfile
> Added Paths
> 
> 	• trunk/dports/graphics/gimp2-devel/files/
> 	• trunk/dports/graphics/gimp2-devel/files/patch-etc-gimprc.diff
> 	• trunk/dports/graphics/gimp2-devel/files/patch-plug-ins-twain-tw_mac.c.diff
> 	• trunk/dports/graphics/gimp2-devel/files/patch-revert-commit-7ef45be8902a4b7403d1d1736ca4f7c95b6449a8.diff
> Diff
> 
> Modified: trunk/dports/graphics/gimp2-devel/Portfile (114580 => 114581)
> 
> --- trunk/dports/graphics/gimp2-devel/Portfile	2013-12-10 17:47:56 UTC (rev 114580)
> +++ trunk/dports/graphics/gimp2-devel/Portfile	2013-12-10 18:02:36 UTC (rev 114581)
> 
> @@ -2,16 +2,17 @@
> 
>  # $Id$
> 
>  
> 
>  PortSystem 1.0
> 
> +PortGroup  compiler_blacklist_versions 1.0
> 
>  
> 
>  name            gimp2-devel
> 
> -version         2.7.5
> -
> -replaced_by     gimp2
> -
> -license         {GPL-3 LGPL}
> 
> +set git_name    gimp
> +set git_commit  8707701bee03db9a67350685adfe1ec85211aef7
> +conflicts       gimp2 gimp3-devel
> +version         2.9.1
> +revision        20131209
> +license         GPL-3+

It can’t be changed now until you increase the version, but the revision field is meant to start at 0 and increase by 1 every time you want the user to rebuild the port for a reason other than an upstream version change. It should not be a large number that looks like a date. It probably belongs in the version field instead, possibly appended to the version number with a dash.

This remark applies to gimp3-devel, gegl-devel, babl-devel as well.

> +variant python26 conflicts no_python python27 description {Use python 2.6} {
> +    configure.python          ${prefix}/bin/python2.6
> +    depends_lib-append        port:py26-pygtk
> +    set python_framework      ${frameworks_dir}/Python.framework/Versions/2.6
> +    configure.pkg_config_path ${python_framework}/lib/pkgconfig
> +    configure.env             PATH=${python_framework}/bin:$env(PATH)
> +}
> +
> +variant python27 conflicts no_python python26 description {Use python 2.7} {
> +    configure.python          ${prefix}/bin/python2.7
> +    depends_lib-append        port:py27-pygtk
> +    set python_framework      ${frameworks_dir}/Python.framework/Versions/2.7
> +    configure.pkg_config_path ${python_framework}/lib/pkgconfig
> +    configure.env             PATH=${python_framework}/bin:$env(PATH)
> +}
> +
> +variant no_python description {Disable Python scripts and filters} {
> +    configure.args-append   --disable-python
> +}
> +
> +if {![variant_isset no_python] && ![variant_isset python26]} {
> +    default_variants +python27
> +}

Variant names beginning with “no_” have been deprecated for years and should not be added to new ports. There’s no need for a “no_python” variant; if the default python is +python27 and the user doesn’t want python, then the user should install the port with -python27.