[115174] trunk/dports/gnome/empathy/Portfile

[David Evans]

On 12/28/13 1:07 AM, Ryan Schmidt wrote:
> On Dec 28, 2013, at 03:04, Jeremy Huddleston Sequoia <jeremyhu at macports.org> wrote:
>
>> On Dec 28, 2013, at 00:50, Ryan Schmidt <ryandesign at macports.org> wrote:
>>
>>> On Dec 27, 2013, at 12:57, jeremyhu at macports.org wrote:
>>>
>>>> Revision
>>>> 115174
>>>> Author
>>>> jeremyhu at macports.org
>>>> Date
>>>> 2013-12-27 10:57:00 -0800 (Fri, 27 Dec 2013)
>>>> Log Message
>>>>
>>>> empathy: Build fix, use geoclue2
>>>> Modified Paths
>>>>
>>>> 	• trunk/dports/gnome/empathy/Portfile
>>>> Diff
>>>>
>>>> Modified: trunk/dports/gnome/empathy/Portfile (115173 => 115174)
>>>>
>>>> --- trunk/dports/gnome/empathy/Portfile	2013-12-27 18:48:18 UTC (rev 115173)
>>>> +++ trunk/dports/gnome/empathy/Portfile	2013-12-27 18:57:00 UTC (rev 115174)
>>>>
>>>> @@ -117,7 +117,7 @@
>>>>
>>>> }
>>>>
>>>>
>>>>
>>>> variant location description {Enable location awareness using geoclue} {
>>>>
>>>> -    depends_lib-append      port:geoclue
>>>>
>>>> +    depends_lib-append      port:geoclue2
>>>>
>>>>    configure.args-replace  --enable-location=no --enable-location=yes
>>>>
>>>> }
>>>>
>>>>
>>>>
>>>> @@ -127,7 +127,7 @@
>>>>
>>>>    configure.args-replace  --enable-goa=no --enable-goa=yes
>>>>
>>>> }
>>>>
>>>>
>>>>
>>>> -default_variants +map +geocode +goa
>>>>
>>>> +default_variants +map +geocode +goa +location
>>> The revision should be increased, so that users who did not have the location variant selected will get it,
>> If they didn't have it before, why would they have it now.  upgrade honors previous variants, right?
> Unless the user had previously explicitly disabled the location variant via
>
> sudo port install empathy -location
>
> the location variant would now be enabled by a rebuild.
>
> But if this variant isn’t that important (i.e. if other ports using empathy don’t depend on this variant being enabled) it could also wait until the next update.
>
>
>>> and so that those who already did have it will use geoclue2 instead (presumably — I don’t see how you’ve informed the build system to use geoclue2 instead of geoclue 1, but perhaps if both are installed that’s what it does automatically).
>> Those who had +location before have been seeing empathy build failures for the past month. Now it will finally build.  The new checksum will tell the build system to clean and rebuild with the new dep.
> Ah ok, I didn’t read the commit message closely enough and missed that this fixed a build failure.
>
> _______________________________________________
> macports-dev mailing list
> macports-dev at lists.macosforge.org
> https://lists.macosforge.org/mailman/listinfo/macports-dev
>
Just to clarify.  In versions of empathy prior to 3.10, the location
variant was enabled by default and used geoclue.  In 3.10, the location
variant requires
geoclue2 and will not build with geoclue although other ports still use
it (e.g. webkit-gtk).  The build failure was brought about by my
disabling +location
as a default until geoclue2 was available -- I should have left the port
at 3.8.  So my fault and the port is now back to its original configuration.