[102521-4] trunk/dports/mail/mu/Portfile

[Ryan Schmidt]

On Feb 4, 2013, at 11:15, sean at macports.org wrote:

> Revision: 102521
>          https://trac.macports.org/changeset/102521
> Author:   sean at macports.org
> Date:     2013-02-04 09:15:24 -0800 (Mon, 04 Feb 2013)
> Log Message:
> -----------
> mu: switch to using github portgroup
> 
> Modified Paths:
> --------------
>    trunk/dports/mail/mu/Portfile
> 
> Modified: trunk/dports/mail/mu/Portfile
> ===================================================================
> --- trunk/dports/mail/mu/Portfile	2013-02-04 17:15:15 UTC (rev 102520)
> +++ trunk/dports/mail/mu/Portfile	2013-02-04 17:15:24 UTC (rev 102521)
> @@ -2,8 +2,9 @@
> # $Id$
> 
> PortSystem          1.0
> -name                mu
> -version             0.9.8.5
> +PortGroup           github 1.0
> +
> +github.setup        djcb mu 0.9.8.5 v
> license             GPL-3
> categories          mail
> maintainers         sean openmaintainer
> @@ -18,12 +19,12 @@
> platforms           darwin
> 
> homepage            http://www.djcbsoftware.nl/code/mu/
> -master_sites        googlecode:mu0
> 
> -checksums           rmd160  dcb943dfd49cb60e3bc3cccb6d15c09d4c38aa70 \
> -                    sha256  41ac0f905487c00e3872d190be7ebb8f6d113318e36a73e344a6f4c266ed79a1
> +checksums           rmd160  82b5621bf826d3e82255895321352f9f76a0337c \
> +                    sha256  edb0f33c436b99eb05f4dd3568684b8f3d61e011832958629c83449fe772dcd7

The file now being downloaded from github is not the same file that was being downloaded from GoogleCode, as evidenced by the checksums having changed. But you've left the filename the same, which will now cause a checksum mismatch for anyone who already had the old distfile, or anyone who gets it from our mirror network:

$ sudo port install mu
--->  Fetching distfiles for mu
--->  Verifying checksum(s) for mu
Error: Checksum (rmd160) mismatch for mu-0.9.8.5.tar.gz
Error: Checksum (sha256) mismatch for mu-0.9.8.5.tar.gz
Error: org.macports.checksum for port mu returned: Unable to verify file checksums

Because in r102523 you updated the port to version 0.99 / 0.9.9, users should not be affected by this anymore, but in the future, please either handle this as a stealth update:

https://trac.macports.org/wiki/PortfileRecipes#stealth-updates

Or better yet would have been to commit the switch to github and the update to 0.99 / 0.9.9 in the same commit.


On Feb 4, 2013, at 11:15, sean at macports.org wrote:

> Revision: 102522
>          https://trac.macports.org/changeset/102522
> Author:   sean at macports.org
> Date:     2013-02-04 09:15:34 -0800 (Mon, 04 Feb 2013)
> Log Message:
> -----------
> mu: add emacs variant to build mu4e
> 
> Modified Paths:
> --------------
>    trunk/dports/mail/mu/Portfile
> 
> Modified: trunk/dports/mail/mu/Portfile
> ===================================================================
> --- trunk/dports/mail/mu/Portfile	2013-02-04 17:15:24 UTC (rev 102521)
> +++ trunk/dports/mail/mu/Portfile	2013-02-04 17:15:34 UTC (rev 102522)
> @@ -28,3 +28,12 @@
> 
> use_autoreconf      yes
> configure.args      --with-gui=none --disable-mu4e --disable-webkit --disable-guile
> +
> +# Note: we don't need an emacs_app variant since (at least currently) they share the same
> +# load path as emacs
> +variant emacs description {Build with emacs bindings} {
> +    depends_lib-append    port:emacs
> +    configure.env-append  EMACS=${prefix}/bin/emacs
> +    configure.args-delete --disable-mu4e
> +    configure.args-append --enable-mu4e
> +}

If you want the emacs-app port to be able to satisfy this dependency you should express it as a path: dependency not a port: dependency.


On Feb 4, 2013, at 11:15, sean at macports.org wrote:

> Revision: 102523
>          https://trac.macports.org/changeset/102523
> Author:   sean at macports.org
> Date:     2013-02-04 09:15:44 -0800 (Mon, 04 Feb 2013)
> Log Message:
> -----------
> mu: update to 0.9.9
> 
> Modified Paths:
> --------------
>    trunk/dports/mail/mu/Portfile
> 
> Modified: trunk/dports/mail/mu/Portfile
> ===================================================================
> --- trunk/dports/mail/mu/Portfile	2013-02-04 17:15:34 UTC (rev 102522)
> +++ trunk/dports/mail/mu/Portfile	2013-02-04 17:15:44 UTC (rev 102523)
> @@ -4,7 +4,8 @@
> PortSystem          1.0
> PortGroup           github 1.0
> 
> -github.setup        djcb mu 0.9.8.5 v
> +github.setup        djcb mu 0.99 v
> +version             0.9.9

Why is there a discrepancy in the version number?


On Feb 4, 2013, at 11:15, sean at macports.org wrote:

> Revision: 102524
>          https://trac.macports.org/changeset/102524
> Author:   sean at macports.org
> Date:     2013-02-04 09:15:54 -0800 (Mon, 04 Feb 2013)
> Log Message:
> -----------
> mu-devel: add subport to mu
> 
> Modified Paths:
> --------------
>    trunk/dports/mail/mu/Portfile
> 
> Modified: trunk/dports/mail/mu/Portfile
> ===================================================================
> --- trunk/dports/mail/mu/Portfile	2013-02-04 17:15:44 UTC (rev 102523)
> +++ trunk/dports/mail/mu/Portfile	2013-02-04 17:15:54 UTC (rev 102524)
> @@ -30,6 +30,15 @@
> use_autoreconf      yes
> configure.args      --with-gui=none --disable-mu4e --disable-webkit --disable-guile
> 
> +subport mu-devel {
> +    github.setup    djcb mu 22e8ae76d759
> +    name            mu-devel
> +    version         0.9.9.0.99
> +
> +    checksums       rmd160  38454b9a00d821486632113f40ed545acc074f62 \
> +                    sha256  1dec2553f32233ffc74fe56ad38a6305854dac1316f60b5b5ff5b7379b919a67
> +}

The mu and mu-devel ports should be marked as conflicting with one another.