[102653-5] trunk/dports/aqua/emacs-mac-app/Portfile

[Sean Farley]

On Wed, Feb 6, 2013 at 7:54 PM, Ryan Schmidt <ryandesign at macports.org> wrote:
>
> On Feb 5, 2013, at 20:04, sean at macports.org wrote:
>
>> Revision: 102653
>>          https://trac.macports.org/changeset/102653
>> Author:   sean at macports.org
>> Date:     2013-02-05 18:04:24 -0800 (Tue, 05 Feb 2013)
>> Log Message:
>> -----------
>> emacs-mac-app: prevent opportunistic linking of librsvg and imagemagick
>>
>> Modified Paths:
>> --------------
>>    trunk/dports/aqua/emacs-mac-app/Portfile
>>
>> Modified: trunk/dports/aqua/emacs-mac-app/Portfile
>> ===================================================================
>> --- trunk/dports/aqua/emacs-mac-app/Portfile  2013-02-06 02:04:16 UTC (rev 102652)
>> +++ trunk/dports/aqua/emacs-mac-app/Portfile  2013-02-06 02:04:24 UTC (rev 102653)
>> @@ -31,7 +31,9 @@
>> universal_variant   no
>>
>> configure.args      --with-mac \
>> -                    --enable-mac-app=${applications_dir}
>> +                    --enable-mac-app=${applications_dir} \
>> +                    --without-rsvg \
>> +                    --without-imagemagick
>
> The port's revision should have been increased with this change, so that any users who had already built emacs-mac-app with the opportunistic linking against librsvg or ImageMagick would be invited to rebuild without it.

Sure, but there was a version increase as well, so that would seem to
cover a rebuild (I think).

> On Feb 5, 2013, at 20:04, sean at macports.org wrote:
>
>> Revision: 102655
>>          https://trac.macports.org/changeset/102655
>> Author:   sean at macports.org
>> Date:     2013-02-05 18:04:40 -0800 (Tue, 05 Feb 2013)
>> Log Message:
>> -----------
>> emacs-mac-app: add imagemagick variant
>>
>> Modified Paths:
>> --------------
>>    trunk/dports/aqua/emacs-mac-app/Portfile
>>
>> Modified: trunk/dports/aqua/emacs-mac-app/Portfile
>> ===================================================================
>> --- trunk/dports/aqua/emacs-mac-app/Portfile  2013-02-06 02:04:32 UTC (rev 102654)
>> +++ trunk/dports/aqua/emacs-mac-app/Portfile  2013-02-06 02:04:40 UTC (rev 102655)
>> @@ -76,3 +76,9 @@
>>     configure.args-delete  --without-rsvg
>>     configure.args-append  --with-rsvg
>> }
>> +
>> +variant imagemagick description {Enable ImageMagick bindings} {
>> +    depends_lib-append     port:imagemagick
>> +    configure.args-delete  --without-imagemagick
>> +    configure.args-append  --with-imagemagick
>> +}
>
> Capitalization is important. The port name is ImageMagick, not imagemagick.

Ah, yes, good point. I can't believe I forgot that >_<