[102861] trunk/dports/aqua/qt4-mac/Portfile

[Ryan Schmidt]

On Feb 9, 2013, at 18:41, Lawrence Velázquez wrote:

> On Feb 9, 2013, at 1:44 PM, michaelld at macports.org wrote:
> 
>> Revision: 102861
>>         https://trac.macports.org/changeset/102861
>> Author:   michaelld at macports.org
>> Date:     2013-02-09 10:44:00 -0800 (Sat, 09 Feb 2013)
>> Log Message:
>> -----------
>> qt4-mac : add NOTE regarding rev-bumping.
> 
> [snip]
> 
>> +# NOTE: Before doing a rev-bump due to an external dependency, please
>> +# contact the maintainer and have him/her do it.  I often have other
>> +# changes to put in place, but hold off doing so until either a
>> +# rev-bump is necessary or I have some critical changes.  Rebuilding
>> +# qt4-mac is quite time consuming, so I make every reasonable effort
>> +# to  require rebuilding it no more often than necessary.  Thanks!
>> revision            4
>> +
>> categories          aqua
>> platforms           macosx
>> maintainers         michaelld openmaintainer
> 
> Maybe qt4-mac shouldn't be openmaintainer?

If someone updates a port to a new library version number, it's that person's responsibility to increase the revision of all ports linking with that library, regardless of maintainership. That's what happened here for jpeg 9 and tiff 4 this weekend, and it'll happen again when I update to icu 50.

Not increasing the revision would mean that for users with rev-upgrade enabled (which is the default), MacPorts would do a rebuild of the port on its own, but keep the same revision. Users installing the port for the first time might receive a binary, which would immediately be declared broken and need to be rebuilt. Then when we finally do get around to increasing the revision, they'll have to rebuild yet again.

For users with rev-upgrade disabled, the port will be silently broken until they decide to manually rebuild it, if they know how to do that.

For big ports like qt4-mac I do usually advocate bundling changes together to reduce rebuilds. But you can't coordinate that in the case of library version number changes like this.

If you have other changes you want to commit to qt4-mac, do it. If we do many updates in quick succession over the weekend it'll only impact the users who happen to update during that time. For the users who wait several days or weeks between updates, they'll just see the last update and only need to rebuild once (or not at all, if they get a binary).