[102941] trunk/dports/graphics/opencv/Portfile

[Ryan Schmidt]

On Feb 10, 2013, at 20:45, jeremyhu at macports.org wrote:

> Revision: 102941
>          https://trac.macports.org/changeset/102941
> Author:   jeremyhu at macports.org
> Date:     2013-02-10 18:45:32 -0800 (Sun, 10 Feb 2013)
> Log Message:
> -----------
> opencv: Use compiler_blacklist_versions
> 
> Modified Paths:
> --------------
>    trunk/dports/graphics/opencv/Portfile
> 
> Modified: trunk/dports/graphics/opencv/Portfile
> ===================================================================
> --- trunk/dports/graphics/opencv/Portfile	2013-02-11 02:45:02 UTC (rev 102940)
> +++ trunk/dports/graphics/opencv/Portfile	2013-02-11 02:45:32 UTC (rev 102941)
> @@ -99,15 +99,13 @@
> set opencv_linker_libs {"-Wl,-headerpad_max_install_names"}
> 
> # gcc-4.0 exits with a bus error
> -compiler.blacklist              gcc-4.0
> +compiler.blacklist-append   gcc-4.0
> 
> # llvm-gcc-4.2 appears to be broken on old XCode (#35368)
> -if {[vercmp $xcodeversion 4.4] <= 0} {
> -    compiler.blacklist-append   llvm-gcc-4.2
> -}
> +compiler.blacklist-append   {llvm-gcc-4.2 < 2336.11}

The build number of llvm-gcc-4.2 is 5658 and has been so from Xcode 3.2.3 all the way through Xcode 4.6:


$ llvm-gcc-4.2 --version
i686-apple-darwin12-llvm-gcc-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.11) (MacPorts llvm-gcc42 2336.11_1+universal)
Copyright (C) 2007 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


You're thinking of the llvm build number, which the compiler_blacklist_versions portgroup does not check. When checking llvm-gcc-4.2, should we be checking the llvm build number instead of the llvm-gcc-4.2 build number? If so we should modify the portgroup.