[103082] trunk/dports/science

[Ryan Schmidt]

On Feb 13, 2013, at 09:43, michaelld at macports.org wrote:

> Revision: 103082
>          https://trac.macports.org/changeset/103082
> Author:   michaelld at macports.org
> Date:     2013-02-13 07:43:47 -0800 (Wed, 13 Feb 2013)
> Log Message:
> -----------
> gr-osmosdr : initial checkin; addresses ticket #38031.
> 
> Added Paths:
> -----------
>    trunk/dports/science/gr-osmosdr/
>    trunk/dports/science/gr-osmosdr/Portfile
>    trunk/dports/science/gr-osmosdr/files/
>    trunk/dports/science/gr-osmosdr/files/patch-cmake_Modules_GrPython.cmake.diff


> +pre-configure       { file mkdir ${workpath}/build }
> +configure.dir       ${workpath}/build
> +build.dir           ${workpath}/build

You might re-use some variables here to avoid repeating the same value three times.


> +variant docs description "Install ${name} documentation" {
> +
> +    depends_lib-append \
> +        port:doxygen

Isn't doxygen only needed at build time?


> +    configure.args-append \
> +        -DDOXYGEN_DOT_EXECUTABLE=/opt/local/bin/dot \
> +        -DDOXYGEN_EXECUTABLE=/opt/local/bin/doxygen

/opt/local should not be hardcoded; use ${prefix} like elsewhere in the portfile.