[103195] trunk/dports/shells/luash

[Ryan Schmidt]

On Feb 18, 2013, at 03:46, and.damore at macports.org wrote:

> Revision: 103195
>          https://trac.macports.org/changeset/103195
> Author:   and.damore at macports.org
> Date:     2013-02-18 01:46:43 -0800 (Mon, 18 Feb 2013)
> Log Message:
> -----------
> port luash: fixed master_sites, added modeline, using the right compiler, installing docs, updated patch
> 
> Modified Paths:
> --------------
>    trunk/dports/shells/luash/Portfile
>    trunk/dports/shells/luash/files/patch-makefile.diff

> +master_sites        http://files.luaforge.net/releases/luash/luash/luash0.9

Should not hardcode the version here; should use the ${version} (or possibly ${branch}) variable.

https://trac.macports.org/wiki/PortfileRecipes#branch


> +distname            ${name}

When updating to the next version, remember to make these changes:

https://trac.macports.org/wiki/PortfileRecipes#unversioned-distfiles


> +build.args-append       CC=${configure.cc} \
> +                        CXX=${configure.cxx} \
> +                        CPP=${configure.cpp}

With this I see you're taking care of UsingTheRightCompiler, but please also take care of using the right -arch flags and adding a universal variant if possible.


> -destroot.env-append PREFIX=${destroot}${prefix}
> +destroot.args       PREFIX=${prefix}
> +post-destroot {
> +    xinstall -d -m 755 ${destroot}$prefix/share/doc/${name}
> +    xinstall    -m 644 -W ${worksrcpath} COPYING README ${destroot}$prefix/share/doc/${name}
> +}

Since this changes what files get installed, the revision should be increased.