[103475] trunk/dports/sysutils/e2fsprogs/Portfile

[Ryan Schmidt]

On Feb 26, 2013, at 17:09, cal at macports.org wrote:

> Revision: 103475
>          https://trac.macports.org/changeset/103475
> Author:   cal at macports.org
> Date:     2013-02-26 15:09:45 -0800 (Tue, 26 Feb 2013)
> Log Message:
> -----------
> libcomerr: don't automatically choose an awk implementation, closes #38214
> 
> Having gawk around at build time would hardcode "gawk" into compile_et. Later
> removal of the gawk port would make that fail, and with that any dependent
> packages (like kerberos5, see #38214).
> 
> I could have avoided the revbump for e2fsprogs by using
>  revision [expr ${revision} + 1].
> However, I didn't, because we should probably first discuss whether this is
> a good idea.
> 
> Modified Paths:
> --------------
>    trunk/dports/sysutils/e2fsprogs/Portfile
> 
> Modified: trunk/dports/sysutils/e2fsprogs/Portfile
> ===================================================================
> --- trunk/dports/sysutils/e2fsprogs/Portfile	2013-02-26 22:54:13 UTC (rev 103474)
> +++ trunk/dports/sysutils/e2fsprogs/Portfile	2013-02-26 23:09:45 UTC (rev 103475)
> @@ -5,7 +5,7 @@
> 
> name                        e2fsprogs
> version                     1.42.7
> -revision                    1
> +revision                    2
> categories                  sysutils
> platforms                   darwin
> maintainers                 nomaintainer
> @@ -64,6 +64,10 @@
> subport libcomerr {
>     license                     MIT BSD
> 
> +    # If we don't force this version of awk, we'd have to add a dependency on
> +    # gawk.
> +    configure.env-append        AWK=/usr/bin/awk
> 

Yes, the revbump of e2fsprogs should have been avoided since it was not necessary.

In my ports I like setting the revision in each subport. And then it's probably a good idea to put a comment near the version line saying not to set the revision there, since others reading the port might not immediately realize that it uses subports.