[101675] trunk/dports/net/smokeping

[Mark Duling]

Hi Ryan,

Thanks for the corrections.  I think I got all the ones you suggested
(r101733) except for finding a smaller piece of  libwww-perl.  I'm not sure
on that what part it uses.  The port isn't tested well but it seemed
totally broken before so I hope I've improved things a little.  I may get
time to check it out later or maybe others can now test it and help make
corrections.  Thanks again.

Mark


On Wed, Jan 16, 2013 at 6:39 PM, Ryan Schmidt <ryandesign at macports.org>wrote:

> On Jan 16, 2013, at 17:43, markd at macports.org wrote:
>
> > Revision: 101675
> >          https://trac.macports.org/changeset/101675
> > Author:   markd at macports.org
> > Date:     2013-01-16 15:43:39 -0800 (Wed, 16 Jan 2013)
> > Log Message:
> > -----------
> > Update to 2.6.8; This version does not use SpeedyCGI.
> >
> > Modified Paths:
> > --------------
> >    trunk/dports/net/smokeping/Portfile
>
> Thanks! I have a few small comments below.
>
>
> > -checksums            md5 eb8e7679fcad35e59d7c51f2328250a2
> > +checksums            md5 14a968daab2d17a27d41600077e3e967
>
> A port should list at least two checksum types for each distfile—or at
> least, should not use only md5 sums, since md5 is a broken algorithm. Using
> only sha256 or only rmd160 is less objectionable, but using both together
> is preferred. We should have lint tell us about this! I filed a ticket for
> that.
>
> https://trac.macports.org/ticket/37667
>
>
> > depends_lib-append    port:perl5.12 \
> > +                     port:mod_fastcgi \
> > +                     port:p5-fcgi \
> > +                     port:apache2 \
> >                       port:rrdtool \
> >                       port:p5.12-libwww-perl \
> > -                     port:p5.12-cgi-speedycgi \
> >                       port:p5.12-socket6 \
> >                       port:p5.12-net-snmp \
> >                       port:p5.12-net-telnet \
>
> You shouldn't depend on stub ports like p5-fcgi; instead, depend on the
> specific subport that you want, which in this case is probably p5.12-fcgi
> to match the other p5.12 dependencies you already have.
>
> libwww-perl was split into several modules so you might try to find out
> which of those modules smokeping actually uses and depend only on those
> instead of p5.12-libwww-perl:
>
> $ port notes p5.12-libwww-perl
> p5.12-libwww-perl has the following notes:
>   As of version 6.00, libwww-perl has been broken up into multiple
> packages. If you were using p5.12-libwww-perl for just one or two of its
> modules before, you may be able to pare down your installation to just
> those modules now. Other important changes have been made that may affect
> your code; for details, please see:
> /opt/local/share/doc/p5.12-libwww-perl/Changes
>
>
> > @@ -95,68 +78,30 @@
> >               ${worksrcpath}/lib/Smokeping/probes/SSH.pm \
> >               ${worksrcpath}/lib/Smokeping/probes/FPing6.pm \
> >               ${worksrcpath}/lib/Smokeping/probes/EchoPing.pm \
> > -             ${worksrcpath}/lib/Smokeping/probes/FPing.pm
> > +             ${worksrcpath}/lib/Smokeping/probes/FPing.pm \
> >
>
> This intrepid little backslash unfortunately doesn't belong here. :)
>
>
> > post-activate {
> > ui_msg "\n  #### To complete the Smokeping installation ####
> >
> > -1) Enable SpeedyCGI (installed as a dependency of Smokeping) for Apache.
> > +1) Enable mod_fastcgi (installed as a dependency of Smokeping) for
> MacPorts Apache 2.
> >
> > -   -For MacPorts Apache 2, add the line below to
> ${prefix}/apache2/conf/httpd.conf.
> > +   -Rdd the line below to ${prefix}/apache2/conf/httpd.conf.
> >
> > -     LoadModule speedycgi_module modules/mod_speedycgi.so
> > +     LoadModule fastcgi_module modules/mod_fastcgi.so
> >
> > -   -For Apple's Apache 2, manually copy mod_speedycgi.so and
> smokeping.cgi
> > -    into place ...
> >
> > -     sudo cp ${prefix}/share/doc/speedycgi/mod_speedycgi.so
> /usr/libexec/apache2
> > -     sudo cp ${prefix}${smokedata}/smokeping.cgi
> /Library/WebServer/CGI-Executables
> > -
> > -   ... and add the lines below to /etc/apache2/httpd.conf.
> > -
> > -     LoadModule speedycgi_module libexec/apache2/mod_speedycgi.so
> > -
> > -
> > 2)  Changes to httpd.conf for Smokeping.
> >
> >    -Uncomment this line to enable the CGI script handler.
> >
>
> You should use notes instead of post-activate ui_msgs.
>
>
> _______________________________________________
> macports-dev mailing list
> macports-dev at lists.macosforge.org
> http://lists.macosforge.org/mailman/listinfo/macports-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/macports-dev/attachments/20130117/092175bc/attachment.html>