[101794] trunk/dports/math

[Ryan Schmidt]

On Jan 19, 2013, at 07:40, hum at macports.org wrote:

> Revision: 101794
>          https://trac.macports.org/changeset/101794
> Author:   hum at macports.org
> Date:     2013-01-19 05:40:38 -0800 (Sat, 19 Jan 2013)
> Log Message:
> -----------
> New port: gibbslda @0.2 - a C/C++ implementation of Latent Dirichlet Allocation (LDA) using Gibbs Sampling.

> Added: trunk/dports/math/gibbslda/Portfile
> ===================================================================
> --- trunk/dports/math/gibbslda/Portfile	                        (rev 0)
> +++ trunk/dports/math/gibbslda/Portfile	2013-01-19 13:40:38 UTC (rev 101794)
> @@ -0,0 +1,49 @@
> +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
> +# $Id$
> +
> +PortSystem          1.0
> +
> +name                gibbslda
> +version             0.2
> +categories          math
> +maintainers         hum openmaintainer
> +
> +description         a C/C++ implementation of Latent Dirichlet Allocation (LDA) using Gibbs Sampling
> +
> +long_description    GibbsLDA++ is a C/C++ implementation of Latent Dirichlet \
> +                    Allocation (LDA) using Gibbs Sampling technique for parameter \
> +                    estimation and inference. It is very fast and is designed to \
> +                    analyze hidden/latent topic structures of large-scale datasets \
> +                    including very large collections of text/Web documents.
> +
> +homepage            http://gibbslda.sourceforge.net/
> +platforms           darwin
> +license             GPL

"license GPL" means any version of the GPL, but the homepage says "License: GibbsLDA++ is a free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version." So this should instead read "license GPL-2+".


> +master_sites        sourceforge:gibbslda

Please rewrite this to avoid HTTP redirects. See:

https://trac.macports.org/wiki/howto/AvoidRedirects


> +build.target        "clean all"

You don't need quotes around this.

Setting build.target to "clean all" seems to be working for me, and the buildbots have built the port ok too, but the concern is that with parallel building, it's possible that "make clean" and "make all" would be run at the same time, and that "make clean" might delete things needed by "make all". It's safer to run "make clean" manually in a post-extract block (if they've distributed a source tarball containing some build artifacts) or pre-build block (if retrying and interrupted build does not otherwise work), that way you can ensure that "make clean" is finished before "make all" begins.