[107845] trunk/base/src/macports1.0/macports.tcl

Joshua Root jmr at macports.org
Sun Jul 7 14:26:54 PDT 2013


On 2013-7-8 06:26 , Lawrence Velázquez wrote:
> On Jul 7, 2013, at 6:36 AM, Joshua Root <jmr at macports.org> wrote:
> 
>> Quotes aren't actually wrong in this context (other than that it's a bit
>> of a wart that expr and if require literal strings to be quoted when Tcl
>> in general does not), and I actually prefer quotes for values where
>> we're not preventing substitutions that would otherwise happen.
> 
> I suppose I look at it the other way. That is, I prefer using quotes if and only if substitution is involved. This also prevents Tcl from checking for substitutions unnecessarily, but I admit that this is certainly premature optimization.

I think it improves readability as well. 'If' conditions can end up
looking like "brace brace brace, brace brace brace brace".

- Josh


More information about the macports-dev mailing list