[108078] trunk/base/src/port1.0/portconfigure.tcl

[Lawrence Velázquez]

On Jul 12, 2013, at 4:22 PM, Lawrence Velázquez <larryv at macports.org> wrote:

> On Jul 12, 2013, at 3:45 PM, Ryan Schmidt <ryandesign at macports.org> wrote:
> 
>> On Jul 12, 2013, at 13:38, larryv at macports.org wrote:
>> 
>>> Revision: 108078
>>>        https://trac.macports.org/changeset/108078
>>> Author:   larryv at macports.org
>>> Date:     2013-07-12 11:38:30 -0700 (Fri, 12 Jul 2013)
>>> Log Message:
>>> -----------
>>> portconfigure.tcl: Make "eval" uses robust.
>> 
>>>               }
>>>           }
>>>           default {
>>> @@ -765,7 +765,7 @@
>>>           append_list_to_environment_value configure "OBJCXXFLAGS" ${configure.universal_objcxxflags}
>>>           append_list_to_environment_value configure "CPPFLAGS" ${configure.universal_cppflags}
>>>           append_list_to_environment_value configure "LDFLAGS" ${configure.universal_ldflags}
>>> -            eval configure.pre_args-append ${configure.universal_args}
>>> +            eval [linsert ${configure.universal_args} 0 configure.pre_args-append]
> 
> This should make sure that any wonky ${configure.universal_args} values are escaped correctly, although this may already be done somewhere else.

It does seem that the "handle_option" proc in portutil.tcl handles this implicitly via its "args" parameter.

vq