[108291] trunk/dports/editors/hexfiend/Portfile

[Ryan Schmidt]

On Jul 17, 2013, at 17:55, cal at macports.org wrote:

> Revision: 108291
>          https://trac.macports.org/changeset/108291
> Author:   cal at macports.org
> Date:     2013-07-17 15:55:36 -0700 (Wed, 17 Jul 2013)
> Log Message:
> -----------
> HexFiend: Provide separate subport for HexFiend.framework, closes #39213
> 
> Modified Paths:
> --------------
>    trunk/dports/editors/hexfiend/Portfile
> 
> Modified: trunk/dports/editors/hexfiend/Portfile
> ===================================================================
> --- trunk/dports/editors/hexfiend/Portfile	2013-07-17 22:53:49 UTC (rev 108290)
> +++ trunk/dports/editors/hexfiend/Portfile	2013-07-17 22:55:36 UTC (rev 108291)
> @@ -17,7 +17,12 @@
> maintainers     dweber cal openmaintainer
> license         BSD
> 
> -description     HexFiend is a fast and clever hex editor
> +# required to build on < Lion
> +patchfiles      framework-sources-HFByteArrayEditScript.m.patch
> +platform darwin 11 {
> +    patchfiles-delete \
> +                framework-sources-HFByteArrayEditScript.m.patch
> +}

Based on the comment, shouldn't we delete the patch when os.major >= 11, not just when os.major == 11?

Or, if the patch does no harm on Lion and later, leave it in. That way a maintainer won't forget to update it.