[108367] trunk/dports/science/gwyddion/Portfile

[Mojca Miklavec]

On Sun, Jul 21, 2013 at 7:55 PM, Frank Schima wrote:
> It's too late now, but it was unnecessary (and undesired) to increase the
> revision due to adding a license and adding a variant.

I agree with this, but I'm still curious about one specific aspect.
Let's say that the user has the port installed with +no_x11 variant
enabled. The option +quartz is added now and then the port is never
updated again for two years. One year from now the compatibility
option no_x11 is removed. So smooth updating experience won't be
possible any more once the need for update arises?

Two more comments:

1.) the code still uses
    if {![variant_isset no_x11]}
instead of asking for existence or non-existence of quartz. This
should probably be fixed?

2.) I'm not aware about the precise macports policy, but: does it make
sense to provide both x11 and quartz, conflicting with each other and
requiring at least one of both to exist? The only reason would be to
make it explicit that x11 is needed, but maybe that's a bad idea
anyway. I'm asking because in the beginning I was trying to make sure
that I've set +no_x11 for every single port, so that I didn't get any
x11 dependencies pulled in.

Mojca

> On Jul 21, 2013, at 8:49 AM, rowue at macports.org wrote:
>
> Revision 108367 Author rowue at macports.org Date 2013-07-21 07:49:29 -0700
> (Sun, 21 Jul 2013)
>
> Log Message
>
> gwyddion: quartz/no_x11
>           added variant quartz
>           set depraced message for variant no_x11
>           set ui_msg for darwin 12, quartz support is
>              currently broken
>
> Modified Paths
>
> trunk/dports/science/gwyddion/Portfile
>
> Diff
>
> Modified: trunk/dports/science/gwyddion/Portfile (108366 => 108367)
>
> --- trunk/dports/science/gwyddion/Portfile 2013-07-21 14:04:14 UTC (rev
> 108366)
> +++ trunk/dports/science/gwyddion/Portfile 2013-07-21 14:49:29 UTC (rev
> 108367)
> @@ -7,7 +7,8 @@
>  version             2.31
>  categories          science x11
>  platforms           darwin
> -revision            2
> +license             GPL
> +revision            3
>  maintainers         rowue gwyddion.net:yeti
>  description         Software for SPM Analysis
>
> @@ -36,8 +37,17 @@
>                      --x-include=${prefix}/include \
>                      --x-lib=${prefix}/lib
>
> +variant quartz description { Build gwyddion with quartz gl support} {
> + platform darwin 12 {
> +    ui_msg "Quartz gl support is currently broken on OS X 10.8"
> + }
> +}
> +
>  variant no_x11 description { Build gwyddion with quartz gl support} {
> -
> + ui_msg "Use of no_x11 is depraced and will be removed - please use quartz
> instead."
> + platform darwin 12 {
> +    ui_msg "Quartz gl support is currently broken on OS X 10.8"
> + }
>  }
>
>  variant debug description { Enable debugging } {