[108379] trunk/dports/python

[Joshua Root]

On 2013-7-22 22:56 , Ryan Schmidt wrote:
> 
> On Jul 21, 2013, at 22:17, larryv at macports.org wrote:
> 
>> Revision: 108379
>>          https://trac.macports.org/changeset/108379
>> Author:   larryv at macports.org
>> Date:     2013-07-21 20:17:15 -0700 (Sun, 21 Jul 2013)
>> Log Message:
>> -----------
>> py2{5,6,7}-pdfrw: New port (#37570).
> 
>> Added: trunk/dports/python/py-pdfrw/Portfile
> 
>> +if {${subport} ne ${name}} {
>> +    # Set this conditionally, or the stub port picks up an unnecessary
>> +    # extract dependency.
>> +    use_zip         yes
> 
> True… However we've made that mistake in virtually every other port that has subports. And nobody on OS X would get an extra port installed, since everyone on OS X already has /usr/bin/unzip. So I'm not terribly concerned about the extra dependency.

And the stub depends on a subport which does use unzip.

> Rather than fix this in every port, I think it would be possible to fix it centrally in the portgroup, just as the portgroup already centrally clears distfiles for you in the stub port.

Nobody suggested fixing it in every port. It's really not worth the
effort of doing anything in the portgroup either. But there's no harm in
putting use_zip inside the if block.

- Josh