[PATCH] Force build from source if macports.conf sets delete_la_files

[Joshua Root]

On 2013-7-23 16:42 , Lawrence Velázquez wrote:
> On Jul 22, 2013, at 11:32 AM, Rainer Müller <raimue at macports.org> wrote:
> 
>> Other options of this kind such as prefix, applications_dir, and
>> frameworks_dir are handled in archive_sites.conf.
>>
>> Shouldn't we add this one there instead?
> 
> I'm not sure that this is the same kind of beast.
> 
> The checks in archive_sites.conf / portarchivefetch.tcl are per-site; they can differ from one archive source to the next, if you specify multiple archive sources.
> 
> On the other hand, this is a global setting that effectively overrides buildfromsource, so it's cleaner (and easier) to handle it where buildfromsource is handled. I tried to implement the check in portarchivefetch.tcl but found that I'd have to also fix _archive_available in portutil.tcl, and who knows what else. It seems better to literally override buildfromsource and leverage all the existing always-build-from-source logic.

What if you set up an archive source that also uses a non-default
setting for delete_la_files?

I still think that accommodating changing this at all gives the false
impression that anyone should be doing it.

- Josh