[108550] trunk/dports/gis

[Ryan Schmidt]

On Jul 26, 2013, at 04:17, vince at macports.org wrote:

> Revision: 108550
>          https://trac.macports.org/changeset/108550
> Author:   vince at macports.org
> Date:     2013-07-26 02:17:27 -0700 (Fri, 26 Jul 2013)
> Log Message:
> -----------
> Initial commit.
> 
> Added Paths:
> -----------
>    trunk/dports/gis/saga/
>    trunk/dports/gis/saga/Portfile
>    trunk/dports/gis/saga/files/
>    trunk/dports/gis/saga/files/patch-configure.diff
>    trunk/dports/gis/saga/files/patch-configure_in.diff
>    trunk/dports/gis/saga/files/patch-pj_proj4_Makefile.diff


> +pre-configure {
> +    system -W ${worksrcpath} "autoreconf -i"

This could be done with:

use_autoreconf yes
autoreconf.args -i

> +    system "cp ${filespath}/patch-configure.diff ${worksrcpath} && \

Since you're not modifying the patchfile (and it would be weird to modify a patchfile) you don't need to copy it.

> +        cd ${worksrcpath} && patch < patch-configure.diff"
> +}

You can use the -W argument to avoid needing to manually run "cd". So you can just:

system -W ${worksrcpath} "patch < ${filespath}/patch-configure.diff"


> Added: trunk/dports/gis/saga/files/patch-pj_proj4_Makefile.diff
> ===================================================================
> --- trunk/dports/gis/saga/files/patch-pj_proj4_Makefile.diff	                        (rev 0)
> +++ trunk/dports/gis/saga/files/patch-pj_proj4_Makefile.diff	2013-07-26 09:17:27 UTC (rev 108550)
> @@ -0,0 +1,11 @@
> +--- src/modules_projection/pj_proj4/pj_proj4/Makefile.orig	2013-07-25 21:13:11.000000000 +0200
> ++++ src/modules_projection/pj_proj4/pj_proj4/Makefile	2013-07-25 21:14:58.000000000 +0200
> +@@ -227,7 +227,7 @@
> + CCDEPMODE = depmode=gcc3
> + CFLAGS = -pipe -arch x86_64
> + CPP = /usr/bin/clang -E
> +-CPPFLAGS = -I/opt/local/include
> ++CPPFLAGS = -I/opt/local/include -I/opt/local/lib/proj47/include
> + CXX = /usr/bin/clang++
> + CXXCPP = /usr/bin/clang++ -E
> + CXXDEPMODE = depmode=gcc3

It's probably a mistake for /opt/local to be hardcoded here. I didn't see a reinplace in the portfile that would fix it.