[108711] trunk/dports/lang/qore

[Ryan Schmidt]

On Jul 31, 2013, at 11:26, Lawrence Velázquez <larryv at macports.org> wrote:

> On Jul 31, 2013, at 7:44 AM, davidnichols at macports.org wrote:
> 
>> Revision: 108711
>>         https://trac.macports.org/changeset/108711
>> Author:   davidnichols at macports.org
>> Date:     2013-07-31 04:44:24 -0700 (Wed, 31 Jul 2013)
>> Log Message:
>> -----------
>> added patches to fix configure with bison >= 3

>> Modified: trunk/dports/lang/qore/Portfile
>> ===================================================================
>> --- trunk/dports/lang/qore/Portfile	2013-07-31 11:22:16 UTC (rev 108710)
>> +++ trunk/dports/lang/qore/Portfile	2013-07-31 11:44:24 UTC (rev 108711)
>> @@ -37,3 +37,6 @@
>> 
>> # the autoconf check for iconv() in libiconv fails with GNU iconv, but we need it, so we turn it on anyway
>> configure.ldflags   -liconv
>> +
>> +patchfiles          patch-qore-configure.ac.diff
>> +patchfiles          patch-qore-configure.diff
> 
> The second "patchfiles" line here overrides the first, so you'll only end up with "patch-qore-configure.diff". You should do something like this instead.
> 
>    patchfiles  patch-qore-configure.ac.diff \
>                patch-qore-configure.diff

Actually there's no reason to patch both.

If you're running auto(re)conf, you must patch configure.ac; there's no point to patching configure.

If you're not running auto(re)conf, you must patch configure; there's no point to patching configure.ac.