[106691] trunk/dports/devel/coccinelle/Portfile

[Ryan Schmidt]

On Jun 5, 2013, at 02:55, g5pw at macports.org wrote:

> Revision: 106691
>          https://trac.macports.org/changeset/106691
> Author:   g5pw at macports.org
> Date:     2013-06-05 00:55:54 -0700 (Wed, 05 Jun 2013)
> Log Message:
> -----------
> devel/coccinelle:
>  fix homepage (I like it better without the slash at the end)
>  add some dependencies and explicitly enable them
>  add variant for pcre
>  fix python variants
> 
> Modified Paths:
> --------------
>    trunk/dports/devel/coccinelle/Portfile
> 
> Modified: trunk/dports/devel/coccinelle/Portfile
> ===================================================================
> --- trunk/dports/devel/coccinelle/Portfile	2013-06-05 07:17:42 UTC (rev 106690)
> +++ trunk/dports/devel/coccinelle/Portfile	2013-06-05 07:55:54 UTC (rev 106691)
> @@ -5,6 +5,7 @@
> 
> name                coccinelle
> version             1.0.0-rc17
> +revision            1
> license             GPL-2
> maintainers         g5pw openmaintainer
> 
> @@ -16,12 +17,14 @@
> 
> platforms           darwin
> 
> -homepage            http://coccinelle.lip6.fr/
> +homepage            http://coccinelle.lip6.fr
> 
> depends_lib         port:ocaml \
>                     port:ocaml-findlib \
> +                    port:ocaml-menhir \
> +                    port:ocaml-pcre


> +variant pcre description {Enable PCRE support} {
> +    configure.args-delete   --disable-pcre
> +    configure.args-append   --enable-pcre
> +
> +    depends_lib			    port:pcre
> +}

You should append to depends_lib, not overwrite it.

However, ocaml-pcre already depends on pcre, so why not enable pcre support always, since it wouldn't add any additional dependencies?