[106768] trunk/dports/_resources/port1.0/group/active_variants-1.1.tcl

Ryan Schmidt ryandesign at macports.org
Fri Jun 7 17:46:03 PDT 2013


On Jun 7, 2013, at 09:52, cal at macports.org wrote:

> Revision: 106768
>          https://trac.macports.org/changeset/106768
> Author:   cal at macports.org
> Date:     2013-06-07 07:52:02 -0700 (Fri, 07 Jun 2013)
> Log Message:
> -----------
> active_variants: don't print depspec in user-visible error message

Thanks; that had been bugging me.


> Modified Paths:
> --------------
>    trunk/dports/_resources/port1.0/group/active_variants-1.1.tcl
> 
> Modified: trunk/dports/_resources/port1.0/group/active_variants-1.1.tcl
> ===================================================================
> --- trunk/dports/_resources/port1.0/group/active_variants-1.1.tcl	2013-06-07 13:58:41 UTC (rev 106767)
> +++ trunk/dports/_resources/port1.0/group/active_variants-1.1.tcl	2013-06-07 14:52:02 UTC (rev 106768)
> @@ -179,10 +179,11 @@
> 	global _require_active_variants_list
> 	foreach _require_active_variant $_require_active_variants_list {
> 		set name [lindex $_require_active_variant 0]

Could we also rewrite this so that this variable is not named "name"? "name" is already a well-known option in portfile syntax; it is confusing to overload its meaning.



More information about the macports-dev mailing list