[107152] trunk/dports/python/py-bpython/Portfile

[Leo Singer]

On Jun 20, 2013, at 12:25 PM, Joshua Root <jmr at macports.org> wrote:

> On 2013-6-21 02:07 , Leo Singer wrote:
>> On Jun 20, 2013, at 4:34 AM,
>> macports-changes-request at lists.macosforge.org
>> <mailto:macports-changes-request at lists.macosforge.org> wrote:
>> 
>>> --- trunk/dports/python/py-bpython/Portfile	2013-06-19 21:01:12 UTC (rev 107151)
>>> +++ trunk/dports/python/py-bpython/Portfile	2013-06-19 21:07:25 UTC (rev 107152)
>>> @@ -28,16 +28,16 @@
>>>     livecheck.type          none
>>> 
>>>     depends_lib-append      port:py${python.version}-parsing \
>>> -                            port:py${python.version}-pygments \
>>> -                            port:py${python.version}-setuptools
>>> +                            port:py${python.version}-pygments
>>> 
>>>     # py-babel is only available for Python 2.x
>>> -    if {[expr ${python.branch} < 3]} { 
>>> +    if {[expr ${python.branch} < 3]} {
>>>         depends_build-append \
>>>                             port:py${python.version}-babel
>>>     }
>>> 
>>> -    depends_build-append    port:py${python.version}-sphinx
>>> +    depends_build-append    port:py${python.version}-sphinx \
>>> +                            port:py${python.version}-setuptools
>>> 
>>>     depends_run-append      port:py${python.version}-urwid \
>>>                             port:bpython_select
>>> 
>> 
>> Actually, setuptools sometime is a library dependency, as it is in this
>> case; some Python packages use the pkg_resources module to locate
>> scripts and data files at runtime:
>> 
>> http://pythonhosted.org/distribute/pkg_resources.html
>> 
>> Take a look at, for example, /opt/local/bin/bpython-2.7.
>> 
>> Would you please revert this commit?
> 
> Sorry about that, I did check the source for imports of setuptools
> modules including pkg_resources and there were none outside of setup.py.
> This appears to be added at build time, which is rather inconvenient.

That's OK. I think that pkg_resources may be needed at run time whenever the entry_points or package_data keyword arguments to setup() are used.

Leo