[104063] trunk/dports/devel/log4cpp/Portfile

[Ryan Schmidt]

On Mar 14, 2013, at 08:30, michaelld at macports.org wrote:

> Revision: 104063
>          https://trac.macports.org/changeset/104063
> Author:   michaelld at macports.org
> Date:     2013-03-14 06:30:46 -0700 (Thu, 14 Mar 2013)
> Log Message:
> -----------
> log4cpp:
> * update to version 1.1;
> * redo autoconf et.al. for modern usage;
> * add license.
> 
> Modified Paths:
> --------------
>    trunk/dports/devel/log4cpp/Portfile


> -master_sites        sourceforge:project/log4cpp/log4cpp-${branch}.x%20%28current%29/log4cpp-${version}
> +master_sites        sourceforge

sourceforge master_sites should be written to reduce redirects, as was done before this change (although the developers rearranged their files and thereby broke our download). See:

https://trac.macports.org/wiki/howto/AvoidRedirects


> +checksums           sha1 6003105dd11b1fe6f0f88b5bc42c86cccd78d5ae

Remember to use at least two checksums per distfile.


> +use_autoconf        yes
> +autoconf.cmd       ${worksrcpath}/autogen.sh


"use_autoconf yes" automatically adds the autoconf, automake and libtool dependencies only if you don't change autoconf.cmd; because you've changed autoconf.cmd, you need to manually add those dependencies if they're needed (which they seem to be). This is why the Mountain Lion buildbot failed to build this port: the version of Xcode on the Mountain Lion buildbot does not include any autotools.


> +post-extract {
> +    move ${worksrcpath}/configure.in ${worksrcpath}/configure.ac
> +    reinplace "s at AM_CONFIG_HEADER@AC_CONFIG_HEADERS at g" \
> +        ${worksrcpath}/configure.ac
> +    reinplace "s at libtoolize@glibtoolize at g" ${worksrcpath}/autogen.sh
> +    reinplace "s at INCLUDES@AM_CPPFLAGS at g" ${worksrcpath}/src/Makefile.am
> +    reinplace "s at INCLUDES@AM_CPPFLAGS at g" ${worksrcpath}/tests/Makefile.am
> +}

reinplacing should happen in post-patch instead of post-extract. Or ideally these would be changed from reinplaces to patchfiles.



I've made these changes in r104072.