[112830] trunk/dports/java/maven-devel/Portfile

Mark Evenson evenson at panix.com
Sun Nov 3 02:15:14 PST 2013



On Nov 3, 2013, at 0:10, Ryan Schmidt <ryandesign at macports.org> wrote:

> 
> On Nov 2, 2013, at 16:39, Frank Schima wrote:
> 
>> 
>> On Nov 2, 2013, at 8:17 AM, easieste at macports.org wrote:
>> 
>>>    # Symlink maven into the bin directory
>>> 
>>> -    system "cd ${destroot}${prefix}/bin && ln -s ../share/java/${name}/bin/mvn mvn3"
>>> 
>>> +    system "cd ${destroot}${prefix}/bin && ln -s ../share/java/${maven_dir}/bin/mvn mvn3”
>>> 
>> 
>> Using system “cd” seems totally unnecessary here. It would be best to only use the ln command and simply use absolute paths for both files. 
> 
> Or use the -W argument of the system command; that’s what it’s for.
> 

Changed to symbolic links in [r112879][].

N.b. both `java/maven3` and `java/maven2`--for neither of which am I
maintainer--contain the same sort of use of "cd <dir> && ln -s <relative path
arguments" removed in this commit.


[r112879]: https://trac.macports.org/changeset/112879


-- 
"A screaming comes across the sky.  It has happened before but there is nothing 
to compare to it now."







More information about the macports-dev mailing list