[113829] trunk/dports/kde/kmix

[Ryan Schmidt]

On Nov 24, 2013, at 09:37, nicos at macports.org wrote:

> Revision
> 113829
> Author
> nicos at macports.org
> Date
> 2013-11-24 07:37:01 -0800 (Sun, 24 Nov 2013)
> Log Message
> 
> kmix: fix build on Mavericks
> Modified Paths
> 
> 	• trunk/dports/kde/kmix/Portfile
> Added Paths
> 
> 	• trunk/dports/kde/kmix/files/patch-C11-headers.diff
> Diff
> 
> Modified: trunk/dports/kde/kmix/Portfile (113828 => 113829)
> 
> --- trunk/dports/kde/kmix/Portfile	2013-11-24 15:35:17 UTC (rev 113828)
> +++ trunk/dports/kde/kmix/Portfile	2013-11-24 15:37:01 UTC (rev 113829)
> 
> @@ -23,6 +23,11 @@
> 
>  depends_lib-append  port:kdelibs4 \
> 
>                      port:libcanberra
> 
>  
> 
> +if { ${os.major} >= 13 } {
> +    #Ensure that proper headers are used
> +    patchfiles-append   patch-C11-headers.diff
> +}

The user might (very hypothetically) not be using Darwin. If you’re checking Darwin version numbers, you should first verify that ${os.platform} eq “darwin”.

However, is checking for Darwin >= 13 really the correct test? Would this patch also be needed if the user has changed their macports.conf to use libc++ on Mountain Lion, for example?