[112272] trunk/dports/audio/ices0/Portfile

[Ryan Schmidt]

On Oct 16, 2013, at 16:05, Eric Gallager <egall at gwmail.gwu.edu> wrote:

>> On Wed, Oct 16, 2013 at 5:00 PM, Ryan Schmidt <ryandesign at macports.org> wrote:
>> 
>> On Oct 16, 2013, at 04:33, jmr at macports.org wrote:
>> 
>> > Revision: 112272
>> >          https://trac.macports.org/changeset/112272
>> > Author:   jmr at macports.org
>> > Date:     2013-10-16 02:33:32 -0700 (Wed, 16 Oct 2013)
>> > Log Message:
>> > -----------
>> > ices0: convert ices.1.in to UTF-8 so sed doesn't fail on 10.8
>> >
>> > Modified Paths:
>> > --------------
>> >    trunk/dports/audio/ices0/Portfile
>> >
>> > Modified: trunk/dports/audio/ices0/Portfile
>> > ===================================================================
>> > --- trunk/dports/audio/ices0/Portfile 2013-10-16 09:22:47 UTC (rev 112271)
>> > +++ trunk/dports/audio/ices0/Portfile 2013-10-16 09:33:32 UTC (rev 112272)
>> > @@ -30,6 +30,10 @@
>> > patchfiles       patch-src-in_mp4.c.diff \
>> >                  patch-r13773.diff
>> >
>> > +post-patch {
>> > +    system -W ${worksrcpath}/doc "iconv -f ISO-8859-1 -t UTF-8 ices.1.in > ices.1.in.new && mv ices.1.in.new ices.1.in"
>> > +}
>> > +
>> 
>> You should probably add a build dependency on libiconv then. It's already there indirectly because it's a library dependency of pkgconfig but you should explicitly list any dependencies you directly use.
> 
> Couldn't a bin-style dependency be used here (i.e. bin:iconv:libiconv) so that /usr/bin/iconv can fulfill it as well?

Yes, if we're sure all versions of OS X-provided iconv work correctly for this use.