[112344] trunk/dports/kde

[Ryan Schmidt]

On Oct 19, 2013, at 05:51, nicos at macports.org wrote:

> Revision: 112344
>          https://trac.macports.org/changeset/112344
> Author:   nicos at macports.org
> Date:     2013-10-19 03:51:50 -0700 (Sat, 19 Oct 2013)
> Log Message:
> -----------
> kdevplatform, kdevelop: prevent use of clang < 5.0.0
> 
> Modified Paths:
> --------------
>    trunk/dports/kde/kdevelop/Portfile
>    trunk/dports/kde/kdevplatform/Portfile
> 
> Modified: trunk/dports/kde/kdevelop/Portfile
> ===================================================================
> --- trunk/dports/kde/kdevelop/Portfile	2013-10-19 10:06:25 UTC (rev 112343)
> +++ trunk/dports/kde/kdevelop/Portfile	2013-10-19 10:51:50 UTC (rev 112344)
> @@ -4,6 +4,7 @@
> PortSystem          1.0
> PortGroup           kde4 1.1
> PortGroup           muniversal 1.0
> +PortGroup           compiler_blacklist_versions 1.0
> 
> name                kdevelop
> version             4.5.1
> @@ -35,6 +36,11 @@
>                     port:kate \
>                     port:oxygen-icons
> 
> +#XCode's clang < 5.0.0 does not compile. Force use of clang to support c++0x
> +if {${configure.compiler} == "clang" && [vercmp $xcodeversion 5.0] < 0} {
> +    configure.compiler  macports-clang-3.3
> +}

Please actually use the compiler_blacklist_versions portgroup for this, by blacklisting the compilers that will not work. For example if clang from Xcode versions < 5.0 doesn't work, consult https://trac.macports.org/wiki/XcodeVersionInfo to learn that Xcode 5.0 included clang version 500.2.75, so you can blacklist "{clang < 500}". Also blacklist equivalent versions of MacPorts clang, assuming they fail in the same way.



> Modified: trunk/dports/kde/kdevplatform/Portfile
> ===================================================================
> --- trunk/dports/kde/kdevplatform/Portfile	2013-10-19 10:06:25 UTC (rev 112343)
> +++ trunk/dports/kde/kdevplatform/Portfile	2013-10-19 10:51:50 UTC (rev 112344)
> @@ -7,6 +7,7 @@
> 
> name                kdevplatform
> version             1.5.1
> +revision            1
> categories          kde kde4
> platforms           darwin
> license             GPL-2+
> @@ -34,6 +35,11 @@
>                     port:boost \
>                     port:grantlee
> 
> +#XCode's clang < 5.0.0 does not compile. Force use of clang to support c++0x
> +if {${configure.compiler} == "clang" && [vercmp $xcodeversion 5.0] < 0} {
> +    configure.compiler  macports-clang-3.3
> +}

Same here. Also, if it was only a compile failure, then the revision increase wasn't needed.