[110954] trunk/dports/_resources/port1.0/group/apache2-1.0.tcl

[Ryan Schmidt]

On Sep 10, 2013, at 23:05, pixilla at macports.org wrote:

> Revision: 110954
>          https://trac.macports.org/changeset/110954
> Author:   pixilla at macports.org
> Date:     2013-09-10 21:05:52 -0700 (Tue, 10 Sep 2013)
> Log Message:
> -----------
> _resources/port1.0/group:
> - Add apache2 port group.
> 
> Added Paths:
> -----------
>    trunk/dports/_resources/port1.0/group/apache2-1.0.tcl

> +# values to be used in eg configuration files
> +#
> +options apache.prefix
> +default apache.prefix           {"${prefix}"}

Usually the namespace used inside the portgroup should match the portgroup's name, e.g. either the portgroup name should be changed to "apache" or the namespace should be changed to "apache2".



> +proc apxsInstall { moduleName activate dylibs } {

> +    if { ${activate} == "yes" } {
> +            exec "${apache.sbindir}/a2enmod" ${moduleName}
> +    }

If $activate is supposed to be a boolean-type variable, then it should be checked using the [tbool] procedure, not by checking for string equality with "yes".