[111271] trunk/dports/science/ocaml-mpi/Portfile

[Eric A. Borisch]

On Wednesday, September 18, 2013, Ryan Schmidt wrote:

> On Sep 17, 2013, at 22:06, eborisch at macports.org <javascript:;> wrote:
>
> > Revision: 111271
> >          https://trac.macports.org/changeset/111271
> > Author:   eborisch at macports.org <javascript:;>
> > Date:     2013-09-17 20:06:42 -0700 (Tue, 17 Sep 2013)
> > Log Message:
> > -----------
> > ocaml-mpi: Update to use new mpich-default
> >
> > Modified Paths:
> > --------------
> >    trunk/dports/science/ocaml-mpi/Portfile
> >
> > Modified: trunk/dports/science/ocaml-mpi/Portfile
> > ===================================================================
> > --- trunk/dports/science/ocaml-mpi/Portfile   2013-09-18 02:18:42 UTC
> (rev 111270)
> > +++ trunk/dports/science/ocaml-mpi/Portfile   2013-09-18 03:06:42 UTC
> (rev 111271)
> > @@ -4,7 +4,7 @@
> >
> > name                ocaml-mpi
> > version             1.01
> > -revision            4
> > +revision            5
> > categories          science devel ml
> > maintainers         mww
> > license             LGPL-2
> > @@ -21,7 +21,7 @@
> >                     sha1    4f836f02f7e8852ba72d4293aea43cf7a3438b0f \
> >                     rmd160  c0a08090073c54e130cd2712c7d1cfbeb8d17793
> >
> > -depends_lib         port:ocaml port:ocaml-findlib path:bin/mpicc:mpich
> > +depends_lib         port:ocaml port:ocaml-findlib
> path:bin/mpicc-mp:mpich-default
> >
> > patchfiles          Makefile.diff
> >
> > @@ -32,7 +32,12 @@
> > use_configure       no
> > use_parallel_build  no
> >
> > -build.env           MPIINCDIR=${prefix}/include/mpich2
> MPILIBDIR=${prefix}/lib
> > +if {[file exists ${prefix}/lib/mpich-mp]} then {
> > +   build.env           MPIINCDIR=${prefix}/include
> MPILIBDIR=${prefix}/lib/mpich-mp
> > +} else {
> > +   build.env           MPIINCDIR=${prefix}/include
> MPILIBDIR=${prefix}/lib/mpich-devel-mp
> > +}
>
> This is concerning, because it means the port builds differently depending
> on what ports the user already has installed. This won't work right if the
> user gets a pre-compiled package from the buildbot and is generally a bad
> idea.
>

True, but the only people it will be any issue for are those that have
intentionally installed mpich-devel-default, and for those, rev-upgrade
will rebuild it locally (the libs are in different locations; no chance of
something subtle slipping by.) The two potential satisfying ports conflict
with each other, so only one can possibly be installed.

These are people who have chosen to go off the beaten path intentionally.

Your thoughts?
  - Eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/macports-dev/attachments/20130918/7ed45202/attachment.html>