[111054] trunk/base/src/port1.0/portconfigure.tcl

Lawrence Velázquez larryv at macports.org
Wed Sep 25 00:09:35 PDT 2013


On Sep 22, 2013, at 2:46 PM, Rainer Müller <raimue at macports.org> wrote:

> On 2013-09-14 03:12, larryv at macports.org wrote:
>> --- trunk/base/src/port1.0/portconfigure.tcl	2013-09-14 00:55:38 UTC (rev 111053)
>> +++ trunk/base/src/port1.0/portconfigure.tcl	2013-09-14 01:12:32 UTC (rev 111054)
>> @@ -51,11 +51,11 @@
>> default configure.nice      {${buildnicevalue}}
>> default configure.dir       {${worksrcpath}}
>> default autoreconf.dir      {${worksrcpath}}
>> -default autoreconf.pre_args {-vi}
>> +default autoreconf.pre_args {{--install --verbose}}
>> default autoconf.dir        {${worksrcpath}}
>> -default autoconf.pre_args   {-v}
>> +default autoconf.pre_args   {--verbose}
>> default automake.dir        {${worksrcpath}}
>> -default automake.pre_args   {-v}
>> +default automake.pre_args   {--verbose}
>> default xmkmf.cmd           xmkmf
>> default xmkmf.dir           {${worksrcpath}}
>> default use_configure       yes
> 
> Is there a reason to use .pre_args instead of .args here? I would prefer
> the latter. I don't think we often want to append something here, but
> rather replace the whole argument string, especially when setting .cmd
> as well.

I can't think of a reason; I just imitated autoreconf.pre_args, which had defaulted to "--install" for a while.

vq


More information about the macports-dev mailing list