[118767] trunk/dports/science/openmpi/Portfile

[Sean Farley]

Joshua Root <jmr at macports.org> writes:

> On 2014-4-12 02:11 , Ryan Schmidt wrote:
>> On Apr 11, 2014, at 11:06, Sean Farley wrote:
>> 
>>> Ryan Schmidt writes:
>>>
>>>> On Apr 10, 2014, at 19:12, sean at macports.org wrote:
>>>>
>>>>> Revision
>>>>> 118767
>>>>> Author
>>>>> sean at macports.org
>>>>> Date
>>>>> 2014-04-10 17:12:52 -0700 (Thu, 10 Apr 2014)
>>>>> Log Message
>>>>>
>>>>> openmpi: check before deleting directory; should fix #42992
>>>>> Modified Paths
>>>>>
>>>>> 	• trunk/dports/science/openmpi/Portfile
>>>>> Diff
>>>>>
>>>>> Modified: trunk/dports/science/openmpi/Portfile (118766 => 118767)
>>>>>
>>>>> --- trunk/dports/science/openmpi/Portfile	2014-04-11 00:12:47 UTC (rev 118766)
>>>>> +++ trunk/dports/science/openmpi/Portfile	2014-04-11 00:12:52 UTC (rev 118767)
>>>>>
>>>>> @@ -143,8 +143,12 @@
>>>>>
>>>>>
>>>>>
>>>>>     post-destroot {
>>>>>
>>>>>         # This version doesn't supply manpages
>>>>>
>>>>> -        delete ${destroot}${prefix}/share/mandelete
>>>>> -        delete ${destroot}${prefix}/share/docdelete
>>>>>
>>>>> +        if {[file isdirectory ${destroot}${prefix}/share/mandelete]} {
>>>>> +            delete ${destroot}${prefix}/share/mandelete
>>>>> +        }
>>>>> +        if {[file isdirectory ${destroot}${prefix}/share/docdelete]} {
>>>>> +            delete ${destroot}${prefix}/share/docdelete
>>>>> +        }
>>>>
>>>> This should not be necessary and this should not change anything.
>>>>
>>>> “delete” is a wrapper around “file delete -force”. 
>>>>
>>>> http://wiki.tcl.tk/10058
>>>>
>>>> “Non-empty directories will be removed only if the -force option is specified.”
>>>>
>>>> “Trying to delete a non-existent file is not considered an error.”
>>>
>>> Huh. Fair enough, but then why did this error out in the ticket
>>> referenced?
>>>
>>> :debug:destroot delete: /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_openmpi/openmpi-default/work/destroot/opt/local/share/docdelete
>>> :error:destroot org.macports.destroot for port openmpi-default returned: /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_openmpi/openmpi-default/work/destroot/opt/local/share/docdelete: no such file or directory
>> 
>> That’s what confuses me too!
>
> Because that change is not released yet?

Ah, ok, then that would explain it.