[123423] trunk/dports/perl/p5-email-mime-contenttype/Portfile

[Frank Schima]

Hi Mojca,


> On Aug 9, 2014, at 4:49 AM, mojca at macports.org wrote:
> 
> Revision
> 123423
> Author
> mojca at macports.org
> Date
> 2014-08-09 03:49:13 -0700 (Sat, 09 Aug 2014)
> Log Message
> 
> p5-email-mime-contenttype: whitespace
> Modified Paths
> 
> trunk/dports/perl/p5-email-mime-contenttype/Portfile
> Diff
> 
> Modified: trunk/dports/perl/p5-email-mime-contenttype/Portfile (123422 => 123423)
> 
> --- trunk/dports/perl/p5-email-mime-contenttype/Portfile	2014-08-09 10:46:40 UTC (rev 123422)
> +++ trunk/dports/perl/p5-email-mime-contenttype/Portfile	2014-08-09 10:49:13 UTC (rev 123423)
> @@ -1,22 +1,22 @@
>  # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
>  # $Id$
>  
> -PortSystem			1.0
> -PortGroup			perl5 1.0
> +PortSystem          1.0
> +PortGroup           perl5 1.0
>  
>  perl5.branches      5.8 5.10 5.12 5.14 5.16 5.18
> -perl5.setup			Email-MIME-ContentType 1.017
> -license				{Artistic-1 GPL}
> -maintainers			nomaintainer
> -description			Parse a MIME Content-Type Header
> -long_description	${description}
> -platforms			darwin
> +perl5.setup         Email-MIME-ContentType 1.017
> +license             {Artistic-1 GPL}
> +maintainers         nomaintainer
> +description         Parse a MIME Content-Type Header
> +long_description    ${description}
> +platforms           darwin
>  
>  checksums           rmd160  8555695b4f57955b28005a275c969d83138dc877 \
>                      sha256  963da3b0446317e64ba3d41f0f59c05475e84fc49080130f6c2099474fa281b2
> -                    
> -supported_archs noarch
>  
> +supported_archs     noarch
> +
>  if {${perl5.major} != ""} {
> -    depends_lib-append  port:p${perl5.major}-capture-tiny
> +depends_lib-append  port:p${perl5.major}-capture-tiny
>  }
Just curious about why you are removing the indenting spacing in these perl ports? I would say it is more common to indent in blocks. I’m open to a discussion about what is preferred. I know when I edit p5 and other ports, I add 4 spaces as indent for all blocks. It makes things much more clear in my mind. I don’t want to get into the situation where people are accidentally reversing each other’s edits! :) I think a consensus would be a good idea here. 

Thanks for cleaning up these ports!


-Frank


> _______________________________________________
> macports-changes mailing list
> macports-changes at lists.macosforge.org
> https://lists.macosforge.org/mailman/listinfo/macports-changes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.macosforge.org/pipermail/macports-dev/attachments/20140809/16d3218c/attachment.html>