[123423] trunk/dports/perl/p5-email-mime-contenttype/Portfile

[Mojca Miklavec]

On Sat, Aug 9, 2014 at 11:34 PM, Marko Käning wrote:
>>> On 8/9/14 12:46 PM, Frank Schima wrote:
>>>> I think the code looks better indented. But I will stay with the consensus on this (of course).
> +1
>
> But, I think, the removal of all these actually needed indentions were surely not intended by Mojca!
>
> (It’s probably just a glitch in the script used for cleaning up the Perl ports...)

Actually, it was intended, but I'm not claiming that it was the best
possible decision.

When cleaning up perl ports I noticed that lots of ports use

if {${perl5.major} != ""} {
<no indent here>
}

And:

- for trivial ports that only have "depends_lib-append p{...}-foo"
lines and alike it actually looks nicer in some way because all
parameters may be indented at 20 characters (else they need to be
indented at 24 or 28 characters and when there are only a few lines,
it doesn't look as nice)

- I thought that this was on purpose and I wanted to make it more or
less consistent


I can switch that back (step-by-step), but I have a tiny request at
the moment. I have a nontrivial number of changes on hold. See
- https://trac.macports.org/ticket/43480#comment:6
- https://trac.macports.org/attachment/ticket/43480/perl5.18-remove-subrelease.diff

I would prefer to wait with indentation (that is: it would be great if
those 300 ports wouldn't be modified too heavily before I commit the
changes, else I'll need to merge the code)..

In any case my question is: do we then have any preferred way to
indent perl ports? Use 28 characters for everything inside the
indentation block?

Mojca