[129459] trunk/dports/multimedia/mpv

[Mihai Moldovan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

[re-sent with correct mail address, so that the post arrives at mp-dev]
On 14.12.2014 03:14 AM, Mihai Moldovan wrote:
> On 14.12.2014 01:04 AM, Ryan Schmidt wrote:
> 
>> On Dec 13, 2014, at 3:29 PM, Mihai Moldovan wrote:
>>> 
>>> On 13.12.2014 08:16 PM, Ryan Schmidt wrote:
>>>>> +# Current waf doesn't support --nocache anymore. Set by PortGroup. 
>>>>> +configure.args-delete   --nocache
>>>> 
>>>> Sounds like the waf 1.0 portgroup should be modified then.
>>>> 
>>>> I couldn't find a port called "waf". Am I correct in assuming that, 
>>>> like "configure", "waf" is a program that is included in its entirety 
>>>> in software that uses it? If so, then the waf portgroup may need a way
>>>>  to select whether it should deal with "old waf" or "new waf". Or maybe
>>>>  there is a better way to distinguish this, perhaps by automatically 
>>>> detecting whether the version of waf supports this flag.
>>> 
>>> The problem at hand is that waf is being most likely downloaded with an 
>>> unspecific version ("current") by I guess most software. I refrained
>>> from changing the PortGroup to not break other ports utilizing waf.
> 
> 
>>>> Ports should not download things other than in the fetch phase. Could 
>>>> this be fixed, please? Add the correct version of waf to the port's 
>>>> distfiles, extract it into the correct place?
>>> 
>>> I should probably inline that. Find a way to fetch a specific version, 
>>> too. Will look into that.
> 
>> mpv, at least, currently fetches exactly 1.8.1.
> 
>> If any port fetches "latest version" that should be fixed as well, because 
>> that results in non-repeatability.
> 
> I would have committed the change hours ago, but might have hit a base
> bug... need to undo and look at what is causing my specific problem (the
> extracted top level directory differs from worksrcdir.)

So, as soon as I use master_sites-append http://ftp.waf.io/pub/release:waf, this
stuff breaks. How is this even possible?

"This stuff" being:
  - worksrcdir is correctly set to
"/opt/local/var/macports/build/_opt_macports_multimedia_mpv/mpv/work/mpv-0.7.1"
on my machine
  - but worksrcdir does not exist, instead...
  - a directory called
"/opt/local/var/macports/build/_opt_macports_multimedia_mpv/mpv/work/mpv-player-mpv-18b15a4"
exists

The mpv distfile does have that "mpv-player-mpv-18b15a4" prefix, but without
master_sites-append, it is renamed to mpv-0.7.1 automatically.

Once I put master_sites-append into the Portfile, this doesn't happen anymore
and everything breaks.

Looks like I have to dive into base and find out what is broken...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCgAGBQJUjPVIAAoJEB/WLtluJTqHJVEQAMeuSssIZVZDjOS9+LNawPAT
CLFnfIvU5UAr5FjCe9QydajmHM74L4uciLj7kCZAXE6fOVMu1sc09AKqkl5bztMm
3AfxSSe+UmRCiYlIZTDM8k+KkxiCjLv8Tzmdxy5uSqt1wgDtw9+Yl3Hy3bx+Hyyz
J0SlrwM2fL8P3P+DTWIdPtFIdOKB7W79bJatScrU3RySTDEQBjfl6fqutkuM1ccw
JfR8leyy6voKYjkcRaC1F+NWhoHTFWYVVGRQBLgrwVppik/4V/j3HPnucGGj7Xyz
kSMFC/yYLMPg7jO6Q2+13wSFT70Pv6cMnzP8RcUVQe2rWvQcgWvOPk2xTuCn7Y/m
a7e5aIzXNJN4buBmBWBZNz+SE7kWb2NQiBGdqGjuB7NNj5y6Nig3UeolylX5WQQ0
wFoSs0GMhFpWucsizXCRHhkGN3m4b1ajteK+Kc6xXwgF6MiqGVkCMCAfJ42IT2i+
YD1PQbZcn/l8E5fyJ6ar4uMCof+UGNPGo0igLJz/bQ+6SpJR3agPo+tPZ+czupoZ
UguqsGLZr8oPjJjQzk+TSYHycNcl0n63fQj+H1hDFfdA7CwN79TMhz7Wh8FaMQmz
RP8NpE+wO56YicR4JP1UV3eDIEiXe2UKwpK2Qf6bEFo2/gEcohiBZa0II0/zeGXG
3GWGKpK2/KnwLRbYPq1A
=Mhhx
-----END PGP SIGNATURE-----